Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviewing GAN basics, VisionDataModule, MNISTDataModule, CIFAR10DataModule #843

Merged
merged 16 commits into from
Jul 29, 2022

Conversation

shivammehta25
Copy link
Contributor

@shivammehta25 shivammehta25 commented Jul 26, 2022

What does this PR do?

Part of #839

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the model label Jul 26, 2022
Copy link
Contributor

@otaj otaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, all in all, it looks good, thank you! 🎉 However, I'd like to be sure that we are not raising any deprecation/user/any other warnings. For this, I just opened #844 which should then be used in tests (when it gets merged).

@@ -13,6 +13,7 @@
[
pytest.param(MNISTDataModule, id="mnist"),
pytest.param(CIFAR10DataModule, id="cifar10"),
pytest.param(STL10DataModule, id="stl10"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove this test case, as it is very heavy dataset

@otaj otaj mentioned this pull request Jul 27, 2022
@shivammehta25
Copy link
Contributor Author

shivammehta25 commented Jul 27, 2022

Currently, all the modified classes and their test cases pass but with the exception that we filter PossibleUserWarning resulting in user suggestions as mentioned in #844 (comment). Also first, #844 should be merged before merging this one as I call the catch_warnings in every test case that I have modified or added.

@otaj
Copy link
Contributor

otaj commented Jul 27, 2022

Awesome work! Let's wait for #844 to see if the tests are passing on CI as well, but otherwise it looks good!

@shivammehta25 shivammehta25 changed the title [WIP] Reviewing GAN basics Reviewing GAN basics, VisionDataModule, MNISTDataModule, CIFAR10DataModule Jul 27, 2022
@shivammehta25 shivammehta25 marked this pull request as ready for review July 27, 2022 16:52
@shivammehta25 shivammehta25 requested a review from otaj July 29, 2022 09:40
Copy link
Contributor

@otaj otaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's wait for test and get this merged 👍 💪 🚀

@mergify mergify bot added the ready label Jul 29, 2022
@otaj otaj merged commit acc0c98 into Lightning-Universe:master Jul 29, 2022
@shivammehta25 shivammehta25 deleted the gan_review branch July 29, 2022 13:19
@@ -30,6 +27,9 @@ def __init__(
shuffle: bool = True,
pin_memory: bool = True,
drop_last: bool = False,
train_transforms: Optional[Callable] = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we include these transforms into the class docstring?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should add it. What will be an ideal way of doing this? Do I need to create another pull request for this?

Copy link
Contributor

@otaj otaj Aug 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this as well, good catch @luca-medeiros!

@shivammehta007, yes, opening a new PR is the only option (not even I have push rights to master 😂). Since this PR is already merged, there really is no other option. Just write there it's a followup of #843

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@otaj

Seems you are the only member doing reviews for #839.
What about assembling a small (3~5 people) team to help you out with it? I would be willing to help review as well!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luca-medeiros Oh, absolutely! That's the whole point of our Slack channel. I think you're not in there yet, can you ping me on PL Slack (@Ota) and I will add you there?

@shivammehta25 shivammehta25 restored the gan_review branch August 1, 2022 10:24
@shivammehta25
Copy link
Contributor Author

As discussed adding docstring in a separate PR #847.

otaj pushed a commit that referenced this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants