Skip to content

Commit

Permalink
[FedCM] Make signin_url required if ISS is enabled
Browse files Browse the repository at this point in the history
When the IDP signin status API is enabled, we need to have a signin_url
so we can show the mismatch dialog. This CL implements that.

Bug: 1472328
Change-Id: I86f7f4f46f0f034ee2a842bae4a476d0e260df7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4897378
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Auto-Submit: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1202887}
  • Loading branch information
cbiesinger authored and Lightning00Blade committed Dec 11, 2023
1 parent 54cc660 commit ee817bb
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 8 deletions.
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"accounts_endpoint": "accounts.py",
"client_metadata_endpoint": "client_metadata.py",
"id_assertion_endpoint": "token.py"
"id_assertion_endpoint": "token.py",
"signin_url": "signin.html"
}
3 changes: 2 additions & 1 deletion credential-management/support/fedcm/manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def main(request, response):
"accounts_endpoint": "accounts.py",
"client_metadata_endpoint": "client_metadata.py",
"id_assertion_endpoint": "token.py",
"revocation_endpoint": "revoke.py"
"revocation_endpoint": "revoke.py",
"signin_url": "signin.html"
}
"""
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"accounts_endpoint": "/common/redirect.py?location=/credential-management/support/fedcm/accounts.py",
"client_metadata_endpoint": "client_metadata.py",
"id_assertion_endpoint": "token.py"
"id_assertion_endpoint": "token.py",
"signin_url": "signin.html"
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@
"accounts_endpoint": "accounts.py",
"client_metadata_endpoint": "client_metadata.py",
"id_assertion_endpoint": "/common/redirect.py?location=/credential-management/support/fedcm/token.py&status=308",
"revocation_endpoint": "revoke.py"
"revocation_endpoint": "revoke.py",
"signin_url": "signin.html"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"accounts_endpoint": "two_accounts.py",
"client_metadata_endpoint": "client_metadata.py",
"id_assertion_endpoint": "token_with_account_auto_selected_flag.py"
"id_assertion_endpoint": "token_with_account_auto_selected_flag.py",
"signin_url": "signin.html"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"accounts_endpoint": "no_accounts.py",
"client_metadata_endpoint": "client_metadata.py",
"id_assertion_endpoint": "token_with_account_id.py"
"id_assertion_endpoint": "token_with_account_id.py",
"signin_url": "signin.html"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"accounts_endpoint": "single_account.py",
"client_metadata_endpoint": "client_metadata.py",
"id_assertion_endpoint": "token_with_account_id.py"
"id_assertion_endpoint": "token_with_account_id.py",
"signin_url": "signin.html"
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"accounts_endpoint": "two_accounts.py",
"client_metadata_endpoint": "client_metadata.py",
"id_assertion_endpoint": "token_with_account_id.py"
"id_assertion_endpoint": "token_with_account_id.py",
"signin_url": "signin.html"
}

0 comments on commit ee817bb

Please sign in to comment.