Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (de)compression transfer ix token pool check #1032

Merged
merged 2 commits into from
Jul 26, 2024
Merged

fix: (de)compression transfer ix token pool check #1032

merged 2 commits into from
Jul 26, 2024

Conversation

ananas-block
Copy link
Contributor

@ananas-block ananas-block commented Jul 25, 2024 •
edited
Loading

Issue:

  • prior token pool check in transfer instruction was insufficient

Changes:

  • create a check token pool derivation function which checks derivation in the compress and decompress function instead of the instruction struct
  • added failing test for invalid token_pool_pda for compressing tokens, adapted error for failing test with decompression

@ananas-block ananas-block requested a review from vadorovsky as a code owner July 25, 2024 16:02
@sergeytimoshin sergeytimoshin self-requested a review July 26, 2024 18:02
@sergeytimoshin sergeytimoshin merged commit f59ffa1 into main Jul 26, 2024
15 checks passed
@sergeytimoshin sergeytimoshin deleted the jorrit/fix-transfer-token-pool-derivation-check branch July 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeytimoshin sergeytimoshin sergeytimoshin approved these changes

@vadorovsky vadorovsky Awaiting requested review from vadorovsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ananas-block @sergeytimoshin