fix(macros): Provide full import paths in light_accounts macro
#1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
vadorovsky
force-pushed
the
vadorovsky/discriminator-macro
branch
from
d430382 to
e62d138
Compare
vadorovsky
force-pushed
the
vadorovsky/macro-light-accounts
branch
from
1ee22b0 to
d2e0e46
Compare
vadorovsky
force-pushed
the
vadorovsky/discriminator-macro
branch
from
e62d138 to
2bfc047
Compare
vadorovsky
force-pushed
the
vadorovsky/macro-light-accounts
branch
2 times, most recently
from
de5d56d to
1d7e40f
Compare
|
thanks! Can you adjust the usage in token-escrow to make use of this? same for #1069 |
vadorovsky
force-pushed
the
vadorovsky/macro-light-accounts
branch
from
4205cb6 to
c3cd6fc
Compare
macros/light/src/traits.rs
Outdated
| #compressed_sol_pda_field | ||
| } | ||
| fn get_compression_recipient(&self) -> Option<&UncheckedAccount<'info>> { | ||
| fn get_compression_recipient(&self) -> Option<&::anchor_lang::prelude::UncheckedAccount<'info>> { |
There was a problem hiding this comment.
can we change the traits to return AccountInfo<'info> or Option<AccountInfo<'info> instead of &UncheckedAccount and Option<UncheckedAccount? To use these in the cpi function we will need to unwrap and do .to_account_info()` to transfer ownership since cpi invocations need to own all data involved and don't work with references.
There was a problem hiding this comment.
see traits in my registry pr for reference
Before this change, using `#[light_accounts]` macro required adding necessary imports manually, e.g. ```rust use account_compression::program::AccountCompression; use light_system_program::program::LightSystemProgram; ``` Which might've been annoying for developers. This change uses full paths for all foregin types used inside macros, so no additional imports are needed.
Before this change, using `#[derive(LightTraits)]` macro required adding
necessary imports manually, e.g.
```rust
use light_sdk::traits::{InvokeAccounts, SignerAccounts};
```
Which might've been annoying for developers.
This change uses full paths for all foreign types used inside macros,
so no additional imports are needed.
Also, remove unnecessary imports.
vadorovsky
force-pushed
the
vadorovsky/macro-light-accounts
branch
from
64e4f0e to
478f848
Compare
SwenSchaeferjohann
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, using
#[light_accounts]macro required adding necessary imports manually, e.g.Which might've been annoying for developers.
This change uses full paths for all foregin types used inside macros, so no additional imports are needed.