feat: forester: do not retry on not eligible slots #1089
Merged
+57
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeytimoshin
changed the title
forester/src/epoch_manager.rs
Outdated
| ); | ||
| return Err(e); | ||
| } | ||
| let delay = BASE_RETRY_DELAY * 2u32.pow(retries as u32); |
There was a problem hiding this comment.
theoretic nit: could use saturating_pow to prevent overflows. anyway don't think it's important because retrys are not gonna overflow in practice
| } | ||
| } | ||
| } | ||
| Err(ForesterError::NotEligible) => { |
There was a problem hiding this comment.
Nice, are there other errors that we need to handle?
For example, edge cases changing epochs before start or after it has ended (might be covered haven't checked).
There was a problem hiding this comment.
Yes, there are still many places in forester where I use ForesterError::Custom(String) generic errors, I should definitely use less generic errors for the specific cases. It's on my list.
…ted the eligibility check to return this error and handle it appropriately during the transaction processing loop.
sergeytimoshin
force-pushed
the
sergey/forester-dont-retry-if-not-eligible
branch
from
33fe10e to
a00f1b4
Compare
Modified the retry delay calculation by using `saturating_mul` and `saturating_pow` to avoid potential overflow issues. This ensures the application remains stable even if the retry count becomes excessively high.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new error variant
NotEligibleinForesterError.Updated the eligibility check to return this error and handle it appropriately during the transaction processing loop.