feat: forester alerts + monitoring #1095
Merged
+1,462
−435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeytimoshin
force-pushed
the
sergey/forester-tracing
branch
2 times, most recently
from
1ab8249 to
54428b5
Compare
sergeytimoshin
changed the title
sergeytimoshin
force-pushed
the
sergey/forester-tracing
branch
from
6af6b71 to
0ef25e8
Compare
• Prometheus metrics sender • Prometheus + AlertManager + PushGateway + Grafana configuration
sergeytimoshin
force-pushed
the
sergey/forester-tracing
branch
from
0ef25e8 to
f796c2d
Compare
| @@ -22,7 +20,71 @@ services: | |||
| - PGADMIN_DEFAULT_PASSWORD=photon | |||
There was a problem hiding this comment.
should we make this an env variable?
(Same question for postgres login above.)
There was a problem hiding this comment.
yes we can, and probably should, it's just a default test value, it implies that the end user should replace it with something more secure
| ports: | ||
| - "3000:3000" | ||
| environment: | ||
| - GF_SECURITY_ADMIN_PASSWORD=admin |
There was a problem hiding this comment.
env variable necessary?
| queue_metric_update(epoch_info.epoch, num_tx_sent, chunk_duration).await; | ||
|
|
||
| // TODO: consider do we really need WorkReport | ||
| self.increment_processed_items_count(epoch_info.epoch, num_tx_sent) |
There was a problem hiding this comment.
I see that we could use it to push things to graphana but in once we have multiple foresters by different parties we should get the performed work from the ForesterEpochPdas and the total performed work from the EpochPda .
| @@ -345,6 +361,7 @@ impl RpcConnection for SolanaRpcConnection { | |||
| } | |||
|
|
|||
| async fn get_slot(&mut self) -> Result<u64, RpcError> { | |||
| println!("Calling get_slot"); | |||
There was a problem hiding this comment.
shouldn't we call info! here?
ananas-block
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
• Tracing-based telemetry
• Prometheus metrics sender
• Prometheus + AlertManager + PushGateway + Grafana docker-compose configuration