Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added rollover logic to forester(once per slot) and test #1134

Merged
merged 3 commits into from
Sep 1, 2024

Conversation

ananas-block
Copy link
Contributor

Issue:

  • foresters only check once per active phase for every tree whether it can be rolledover, for long epochs with high traffic this is insufficient

Changes:

  • check whether a tree can be rolledover once per light slot
  • move rollover into process_queue
  • modify test to test a rollover

@ananas-block ananas-block force-pushed the jorrit/chore-trigger-rollover-once-per-slot branch from 78e3bfe to 696b5a6 Compare September 1, 2024 00:51
Comment on lines +86 to +89
// let account_info = rpc
// .get_account(account.metadata.associated_queue)
// .await?
// .unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it on purpose so that we know that we need to take the queue account info not the Merkle tree.
This is different for state and address Merkle trees because for address Merkle trees users only interact with the queue the tree is only updated by the forester.

@ananas-block ananas-block merged commit 1b2a327 into main Sep 1, 2024
15 checks passed
@ananas-block ananas-block deleted the jorrit/chore-trigger-rollover-once-per-slot branch September 1, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants