chore: review-cleanup #929
Conversation
ananas-block
force-pushed
the
jorrit/review-cleanup
branch
from
984de4b to
ee6f87a
Compare
ananas-block
force-pushed
the
jorrit/review-cleanup
branch
2 times, most recently
from
6c14282 to
a28e3fe
Compare
ananas-block
force-pushed
the
jorrit/review-cleanup
branch
from
a28e3fe to
c2fa8f9
Compare
| }, | ||
| { | ||
| name: 'solPoolPda'; | ||
| isMut: true; | ||
| isSigner: false; | ||
| isOptional: true; | ||
| docs: [ | ||
| 'Sol pool pda is used to store compressed sol.', |
There was a problem hiding this comment.
doesn't actually store compressed sol but native sol, so may be confusing
There was a problem hiding this comment.
Joa both not wrong, the native sol that has been compressed.
Makes sense to be explicit let me fix it in https://github.com/Lightprotocol/light-protocol/actions/runs/9754900751/job/26922536668?pr=931 since the tests are already green here.
| }, | ||
| { | ||
| name: 'accountCompressionProgram', | ||
| isMut: false, | ||
| isSigner: false, | ||
| docs: ['Merkle trees.'], |
There was a problem hiding this comment.
This is an error in the idl the full comment reads:
/// CHECK: Account compression program is used to update state and address
/// Merkle trees.
```
| if inputs.is_compress { | ||
| compress_lamports(inputs, ctx) | ||
| } else if inputs.compress_or_decompress_lamports.is_some() { | ||
| decompress_lamports(inputs, ctx) | ||
| } else { | ||
| Ok(()) | ||
| decompress_lamports(inputs, ctx) | ||
| } | ||
| } |
There was a problem hiding this comment.
this is now by default always going to execute decompress_lamports(),no?
is_compress is not optional, so the default usage is is_compress = false, compress_or_decompress_lamports = None.
There was a problem hiding this comment.
The function yes but we only execute the function when compress_or_decompress_lamports is some.
Hence, this function will never be executed if we don't want to compress or decompress.
| @@ -61,9 +59,7 @@ pub fn decompress_lamports< | |||
| None => return err!(SystemProgramError::DeCompressLamportsUndefinedForDecompressSol), | |||
| }; | |||
|
|
|||
| transfer_lamports(&sol_pool_pda, &recipient, lamports)?; | |||
|
|
|||
| Ok(()) | |||
There was a problem hiding this comment.
does it make any difference to not emit Ok(()) here
There was a problem hiding this comment.
It's cleaner not to
Changes:
indices->leaf_indicesmerkle_tree.sequence_numberafter it has been incrementedrootstoinput_compressed_account_rootsfetch_roots->fetch_input_compressed_account_rootshash_input_compressed_accounts-> enforce input ordering because we allow Merkle trees to be inserted into hashed_pubkeys without checking whether these exist already