fix: Handle invalid (zero) capacity of changelog and roots reliably #930
+349
−334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
vadorovsky/test-minimum-config
branch
from
e99dfdb to
427caa8
Compare
ananas-block
reviewed
Jul 2, 2024
ananas-block
approved these changes
Jul 2, 2024
ananas-block
requested changes
Jul 2, 2024
ananas-block
reviewed
Jul 2, 2024
test-programs/account-compression-test/tests/address_merkle_tree_tests.rs
Outdated
Show resolved
Hide resolved
ananas-block
reviewed
Jul 2, 2024
| for changelog_size in (1..=5000).step_by(1000) { | ||
| for roots_size in (changelog_size..=5000).step_by(1000) { | ||
| for queue_capacity in [5003, 6857, 7901] { | ||
| test_init_and_insert_into_nullifier_queue( |
There was a problem hiding this comment.
I think this one makes sense to iterate over multiple capacities.
I don't know how the underlying test works but it's probably enough to just do a couple inserts and empty the queue no need to do a lot of transactions here, imo.
ananas-block
reviewed
Jul 2, 2024
| canopy_depth: ADDRESS_MERKLE_TREE_CANOPY_DEPTH, | ||
| address_changelog_size, | ||
| network_fee: Some(5000), | ||
| rollover_threshold: Some(95), |
There was a problem hiding this comment.
Iterations make sense!
We can just put the rollover threshold to zero to test this one, that should be faster.
Imo we should still keep one test that advances the slot and modifies the account (idk whether these replaced that original test which did that.)
vadorovsky
force-pushed
the
vadorovsky/test-minimum-config
branch
3 times, most recently
from
48a5090 to
2df375c
Compare
* Validate changelog and roots size not only in `new()` method, but also in `init()` and all wrapper types (zero-copy and copy). * Add SBF tests which initialize trees with zero capacities and expect an error. * Add SBF tests with changelog and root capacity 1. They are expected to succeed.
Having them everywhere makes test runs on CI too long.
Not defining it violates asserts.
ananas-block
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new()method, but also ininit()and all wrapper types (zero-copy and copy).