Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add wide hash set steps #961

Merged
merged 3 commits into from
Jul 10, 2024
Merged

fix: add wide hash set steps #961

merged 3 commits into from
Jul 10, 2024

Conversation

ananas-block
Copy link
Contributor

@ananas-block ananas-block commented Jul 5, 2024

Issue:

  • the current hash-set seems to perform poorly in practice because it iterates only over a small part of the hash-set

Changes:

  • increase step size relative to capacity

Note:

  • some tests depend on linear filling which does not work anymore because of the increased step size this is expected
  • adapted most tests, removed two which were just asserting linear filling

@ananas-block ananas-block force-pushed the jorrit/fix-hash-set-steps branch from 48774cb to ac7bf36 Compare July 5, 2024 04:41
@ananas-block ananas-block marked this pull request as ready for review July 8, 2024 14:51
@ananas-block ananas-block requested a review from vadorovsky as a code owner July 8, 2024 14:51
@ananas-block ananas-block force-pushed the jorrit/fix-hash-set-steps branch from ac7bf36 to b414dd2 Compare July 10, 2024 22:10
@ananas-block ananas-block merged commit fd87b1b into main Jul 10, 2024
14 checks passed
@ananas-block ananas-block deleted the jorrit/fix-hash-set-steps branch July 10, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants