Nimble: update to latest upstream and make it Xcode12 ready.

[arangato]

• Apply project settings recommended by Xcode12.
• Removed usage of expectation and matching API based on deprecated Matcher protocol.
  Otherwise matching expect statement on an optional value often resulted in the following warning
  'to(:description:)' is deprecated: User Predicate instead_.

[nicklockwood]

Looks fine to me. Just one query about the changes to expect(expression:).

[nicklockwood]

LGTM. Merge when ready.

[byohay]

I'm missing a few things:

• What ambiguity are you trying to solve? An explanation and an example would be great.
• How does the the change in the code solve it? It's not immediately apparent from the code.
• There are commits that don't seem related to Xcode 12, for example removing deprecated APIs. Why are they here then?

[byohay]

So what's this for?

[arangato]

this is the one recommended by Xcode. It was before I learned NO is as good, but since it's working already no reason to change.

[ashdnazg]

Note that upstream has now solved the ambiguity/crash issue and is XCode 12 ready Quick#824

[arangato]

Note that upstream has now solved the ambiguity/crash issue and is XCode 12 ready Quick#824

Yep. I saw it. We'll advance our fork and I'll drop whatever I could from this PR. We don't want to diverge at all. But some upstream changes (like dropping deprecated Matcher API) we'd rather not wait, because they cause unnecessary noise.

[arangato]

@barakwei please advance Nimble fork to v9.0.0-rc.3 as it incorporates ambiguous use of 'expect' fix I previously cherry picked.

[barakwei]

pulled master, good luck

[arangato]

@byohay have a look. I removed details of "ambiguous expect" since it's not part of the PR anymore. I'll write about it on ++Nimble in Foundations.

[barakwei]

Can we ++Nimble even before this is merged?

[arangato]

If we do, some apps will get to(_:description:)' is deprecated: Use Predicate instead warnings. FacetuneVideo for example has lots of there.

[byohay]

There are more deprecated stuff:

• Matcher protocol.
• NMBObjCMatcher
• expressionDoesNotMatch
• postNotifications
• _fromDeprecatedClosure, but it seems to be deeply engrained in Predicate.

What about them?

[arangato]

I tried removing those but it's tricky and has no real value. I surveyed several apps to find all the deprecated APIs that have negative impact. In addition I deleted all Matcher usages that were easy to delete just in case.
Nimble has pretty solid deprecation plan. Once they properly remove it we'll switch to upstream version.

[byohay]

@barakwei merge at your leisure, for some reason I can't.