16주차 Assignment - 김무빈 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khj0426
approved these changes
Nov 14, 2024
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> |
There was a problem hiding this comment.
요런 기본적은 meta태그 말고도 og태그도 있씁니다.
og태그는 썸네일같은 건데요..링크 공유 할 떄 보이는 친구가 og태그입니당
| password: | ||
| <input type="password" id="signInPassword" required /> | ||
| </div> | ||
| <button id="signInButton" type="submit">로그인</button> |
There was a problem hiding this comment.
버튼의 type의 기본 값이 submit이라 요건 명시적으로 안적어줘도 됩니당
| </div> | ||
| <div> | ||
| password: | ||
| <input type="password" id="signInPassword" required /> |
There was a problem hiding this comment.
만약 비밀번호가 8글자 이상 16글자 이하다 라는 요구사항이 추가되면 요 input에 어떤 것을 넣어주면 될까요!??
| </div> | ||
| </form> | ||
|
|
||
| <script type="module"> |
| signInWithEmailAndPassword, | ||
| } from 'https://www.gstatic.com/firebasejs/11.0.1/firebase-auth.js'; | ||
|
|
||
| const firebaseConfig = { |
There was a problem hiding this comment.
요런 중요한 값들 개인토큰이나 서버의 API주소는 보통 환경변수로 주입하기도 한답니다
| document | ||
| .getElementById('signupButton') | ||
| .addEventListener('click', (event) => { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
script태그 안에 여러 비동기 함수들이 쭉 늘어져 있는데요 then catch체이닝 말고 async/await란 문법으로 더 깔끔하게 짜보는 것도 시도할 법할 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<!— 구현 및 작업 내용을 적어주세요(지우고 작성해주세요) —>
Important content
<!— 주의 깊게 봐줬으면 하는 부분을 적어주세요(지우고 작성해주세요) —>
Question
<!— 궁금한 점을 적어주세요(지우고 작성해주세요) —>
Reference
<!— 참고한 레퍼런스가 있다면 공유해 주세요(지우고 작성해주세요) —>