16주차 Assignment - 양라윤 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khj0426
reviewed
Nov 14, 2024
There was a problem hiding this comment.
요 파일은 처음 봤는데, 아래와 같은 역할을 한다구 하네요!
웹앱 매니페스트란 앱에 대한 정보를 담고 JSON 파일이다.
배경색은 어떠한 색인지, 앱의 이름은 무엇인지, 홈스크린 화면에 추가할 때 아이콘은 어떤 것인지 등의 정보를 담고 있다.
| return; | ||
| } | ||
|
|
||
| createUserWithEmailAndPassword(auth, email, password) |
There was a problem hiding this comment.
만약 요 비동기 함수를 끝내고 또 다른 비동기 함수를 then, catch로 호출하면 들여쓰기도 많아지고, 읽기도 힘들어질거에요.
그래서 주로 가독성이나, 너무 많은 then 체이닝을 방지하기 위해 async await문법을 쓰기도 해요!
async awiat에 대해서 공부해도 좋을 것 같아요
| const email = document.getElementById("signupEmail").value.trim(); | ||
| const password = document.getElementById("signUpPassword").value; | ||
|
|
||
| if (!email || !/^[^\s@]+@[^\s@]+\.[^\s@]+$/.test(email)) { |
There was a problem hiding this comment.
요런 검증부 로직은 개인적으로 독립적인 공간에 있으면 좋다고 생각하는데요.
예를 들어 특정 컴포넌트 -> 이메일 형식의 input이 필요함
요 경우에는 컴포넌트에서 검증부 로직을 위치하는 것보다 validation을 모아두는 계층을 만드는 것도 방법이랍니다
|
|
||
| // Your web app's Firebase configuration | ||
| // For Firebase JS SDK v7.20.0 and later, measurementId is optional | ||
| const firebaseConfig = { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important content
Question
Reference
강의자료