Switch from unmaintained appdirs to the drop-in replacement platformdirs #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't open an issue or search for code use since this is marked as a fork, so I cloned the repo and went straight for a PR; hope that's okay.
In any case, for some background, I'd observed a crash in the PRAW pre-commit suite that I discovered was fixed in #30 while working on the PR we've discussed to simplify and unify the PRAW linting situation, which ironically enough apparently initially went unnoticed due to that very issue (as otherwise the CIs would have immediately flagged the issue), the linting suite on the CIs and in the pre-push script having different versions and config then the pre-commit suite and not running in isolated envs (I'll pre-commit autoupdate to pull in the fixed version).
Anyway, all that aside, given it was just added as a dep I wanted to let you know that appdirs is effectively unmaintained and platformdirs is the community's drop-in replacement.
Black, Pylint and other major projects have already switched, and given this dep was newly added, it would make sense to use the modern, maintained replacement now given its drop-in compatible and fixes numerous long-outstanding bugs with the original, instead of having to switch later when things eventually break. It also slightly simplifies the code, as
platformdirs
has native support for outputingpathlib.Path
s.