Base.hash for test statistics (JuliaLang#670)

* Base.hash for test statistics * woops, simple equality
LilithHafner · Mar 15, 2021 · f32d0f1 · f32d0f1
1 parent 7089961
commit f32d0f1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/statmodels.jl b/src/statmodels.jl
@@ -489,13 +489,14 @@ for op in [:(==), :<, :≤, :>, :≥, :(isless), :(isequal)] # isless and < to p
     end
 end
 
+Base.hash(x::Union{TestStat, PValue}, h::UInt) = hash(x.v, h)
+
 # necessary to avoid a method ambiguity with isless(::TestStat, NaN)
 Base.isless(x::Union{TestStat, PValue}, y::AbstractFloat) = isless(x.v, y)
 Base.isless(y::AbstractFloat, x::Union{TestStat, PValue},) = isless(y, x.v)
 Base.isequal(y::AbstractFloat, x::Union{TestStat, PValue}) = isequal(y, x.v)
 Base.isequal(x::Union{TestStat, PValue}, y::AbstractFloat) = isequal(x.v, y)
 
-
 Base.isapprox(x::Union{TestStat, PValue}, y::Real; kwargs...) = isapprox(x.v, y; kwargs...)
 Base.isapprox(y::Real, x::Union{TestStat, PValue}; kwargs...) = isapprox(y, x.v; kwargs...)
 Base.isapprox(x1::Union{TestStat, PValue}, x2::Union{TestStat, PValue}; kwargs...) = isapprox(x1.v, x2.v; kwargs...)

diff --git a/test/statmodels.jl b/test/statmodels.jl
@@ -86,6 +86,8 @@ end
         @test Rational(1,3) ≈ T(1/3) atol=0.01
         @test T(Rational(1,3)) isa Real
         @test T(T(0.05)) === T(0.05)
+        @test hash(T(0.05)) == hash(0.05)
+        @test hash(T(0.05), UInt(42)) == hash(0.05, UInt(42))
     end
 end