Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor API fetching to be DRY #123

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor API fetching to be DRY #123

wants to merge 1 commit into from

Conversation

DevlinRocha
Copy link
Collaborator

@DevlinRocha DevlinRocha commented Jan 21, 2025 •
edited
Loading

Summary

  • when reviewing Noryev/fix webui #122 i noticed we had a lot of repeated code that could be refactored to be more DRY

  • logic is the same and should work the same. need to get doppler running locally to test properly on my end

  • this is a draft until properly tested

  • prettier messed up the formatting as well, will need to fix this to correct the diff

    • we should consider creating a .prettierrc.cjs in version control

@DevlinRocha DevlinRocha added the enhancement New feature or request label Jan 21, 2025
@DevlinRocha DevlinRocha self-assigned this Jan 21, 2025
@DevlinRocha
Copy link
Collaborator Author

@noryev would you mind sharing your prettier config so i can use it on my machine and fix the formatting/whitespace diff?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noryev noryev Awaiting requested review from noryev

@PBillingsby PBillingsby Awaiting requested review from PBillingsby

Assignees

@DevlinRocha DevlinRocha

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DevlinRocha