CICD workflow updates #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AquiGorka
reviewed
Jun 7, 2024
| @@ -8,7 +8,7 @@ on: | |||
| jobs: | |||
| build: | |||
| runs-on: ubuntu-latest | |||
| environment: devbuild | |||
| environment: devnet | |||
There was a problem hiding this comment.
Wait, does doppler understand this in order to grab the different key/values? It looks like that's the case, nice find!
In the past we've added different doppler tokens per environment, I think that is more explicit and less magical but good to now we can also do this.
cc @bgins
There was a problem hiding this comment.
Yes because I'm using two different sets of github actions environment secrets with different doppler tokens on both action flows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed sync flow and added testnet and devnet flows with different env secrets