Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement functionality for getting the last finalized block #655

Closed
Tracked by #654
georg-getz opened this issue Dec 10, 2024 · 0 comments · Fixed by #727
Closed
Tracked by #654

Implement functionality for getting the last finalized block #655

georg-getz opened this issue Dec 10, 2024 · 0 comments · Fixed by #727
Assignees

Comments

@georg-getz
Copy link
Member

No description provided.

@georg-getz georg-getz changed the title /implement functionality for getting the last finalized block Implement functionality for getting the last finalized block Dec 10, 2024
@Grigorov-Georgi Grigorov-Georgi self-assigned this Jan 7, 2025
Grigorov-Georgi added a commit that referenced this issue Feb 3, 2025
# Description

- JustificationVerifier.verify() method now has Justification as an
input parameter and also executes block ancestry validation
- JustificationVerifier.verify() method checks if there are more than 3
votes cast by single authority. The vote with the smaller block number
is considered as the valid vote, other two are counted as equivocations.
- Replace PreCommit with SignedVote in all places and delete PreCommit
object

Fixes: #655 &
#648
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants