feat: Implement Finalize stage in Play-Grandpa-Round. #750
Conversation
|
|
||
| private boolean isRoundReadyToEnd(GrandpaRound round) { | ||
| BlockHeader finalized = round.getFinalizedBlock(); |
There was a problem hiding this comment.
You should use try-catch instead of null check for this one.
public BlockHeader getFinalizedBlock() {
if (finalizedBlock == null) throw new GrandpaGenericException("Finalized block has not been set.");
return finalizedBlock;
}
There was a problem hiding this comment.
The idea here is that if finalized is null, it means that round is not ready to be finalized. The method should return false(we are in waiting for preCommits as not eligible to finalize) and then the callback should be passed to the GrandpaRound handler. Then on each preCommit message, we attemptToFinalize the round and execute the logic from the callback.
There was a problem hiding this comment.
Return false in the catch if getter throws an error.
There was a problem hiding this comment.
I probably didn't describe well what I meant, but I guess after @Zurcusa's clarification you get the point.
| return; | ||
| } | ||
|
|
||
| Runnable onFinalizeHandler = () -> { |
There was a problem hiding this comment.
I think we have this inline when we invoke setOnFinalizeHandler
| try { | ||
| finalized = round.getFinalizedBlock(); | ||
| } catch (GrandpaGenericException e) { | ||
| return false; |
There was a problem hiding this comment.
Maybe add a warning log here.
|
Description
Fixes #729