Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add asserts with custom messages #408

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

dimitrovmaksim
Copy link
Member

@dimitrovmaksim dimitrovmaksim commented Sep 12, 2023

Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim dimitrovmaksim marked this pull request as ready for review September 12, 2023 12:29
…il test instead of panicing

Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
@dimitrovmaksim dimitrovmaksim merged commit b3af1bd into main Sep 13, 2023
4 checks passed
@dimitrovmaksim dimitrovmaksim deleted the add-custom-messages-to-asserts branch September 13, 2023 10:09
dimitrovmaksim added a commit that referenced this pull request Sep 13, 2023
* feat: Add asserts with custom messages

Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>

* chore: Run fmt

Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>

* refactor: Use logging::critical instead of panic. Return error and fail test instead of panicing

Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>

* chore: Run fmt

Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>

---------

Signed-off-by: Maksim Dimitrov <dimitrov.maksim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants