Build a macOS app bundle and publish macOS and Linux distributables, clean up binary asset names. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't work in macOS app bundles, as they're mounted in a read-only filesystem. In the future, we should put logs in the AppData directory.
on macOS, rename release assets and add macOS distributable.
dgavedissian
commented
May 27, 2024
| // TODO: do we really need this magic? | ||
| std::env::set_current_dir("../").expect("Cannot change folder to parent"); | ||
| // If we can't find it, set the current dir to one above the executable path and try that instead. | ||
| let mut dir = std::env::current_exe().expect("Cannot get the path to the executable"); |
There was a problem hiding this comment.
I added this so that we always try relative to the actual executable, rather than relative to whatever the working directory happens to be right now.
|
Final artifacts:
|
|
I added rust-cache to the PR build as well in d39b86e, and changed the release workflow to use the shared cache key, so now I think the cache should be shared across all branches when the dependencies don't change. Reduce the macOS and Windows build+test times down from 16 minutes to 8 minutes. |
dgavedissian
changed the title
IllustrisJack
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
ltheory-bin-win32.zip->dev-binaries-windows.zipltheory-bin-macos.zip->dev-binaries-macos.zipltheory-bin-ubuntu2004.zip->dev-binaries-linux.zipltheory-distro-win32.zip->ltheory-windows.zip.ltheory-macos.zip, containing the macOS app bundle (x86_64 only).ltheory-linux.zip, containing the Ubuntu binaries.I also renamed
lt64toltrin the binary and distro packages.These changes will break the launcher, but should make the assets much more obvious in the future.
Closes #263