Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for importing RSA public key #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xinyu-tfm
Copy link
Contributor

This PR adds support for importing RSA public key, and also contains a tiny update on getting pk info with mbedtls_pk_info_from_type().

"mbedtls_rsa_info" is defined in pk_wrap.c and declared as an extern
in pk_wrap.h. But pk_wrap.h is neither explicitly nor implicitly
included in iot_pkcs11_psa.c.

It is a better way to get pk info via mbedtls_pk_info_from_type().

Signed-off-by: Xinyu Zhang <xinyu.zhang@arm.com>
Change-Id: I55e9d0d5e6b4b04c779c8bf2882c1fc9ed2f4d56
Signed-off-by: Xinyu Zhang <xinyu.zhang@arm.com>
Change-Id: Ia8b15b2e92e17acad5ec0b2a9841032dd8cb0a58
@xinyu-tfm xinyu-tfm marked this pull request as ready for review March 21, 2023 09:02
Copy link
Contributor

@Sherryzhang2 Sherryzhang2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants