-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all requirements #136
Conversation
A lot of requirements have sequrity warnings and looks quite out of date. It's good praxis to keep up to date.
Right. It seems like wikmd still have support for Python 3.7. The 3.x version of flask is only python 3.8 or higher. 3.7 has already passed the end-of-life stage so it could be a valid consideration to drop the 3.7 support. I am not sure how most people run it, personally I do it through a docker image so the python version has minimal impact on that. However that is 100% up to you @Linbreux |
Updating the requirements was on top of the Todo list! We can drop support for Looks like not all tests succeeded. So maybe try to fix this before we merge. |
It's a search issue, it seems like watchdog doesn't fire off the events properly. However I have never gotten the search to work on my Windows computer (going back) so I can't really debug it :( I tried using PollingObserver as this Issue points out #122 but it never worked with that either. |
For now I rolled back the version of the watchdog from |
Summary
A lot of requirements have security warnings and looks quite out of date.
It's good praxis to keep up to date.
Details
I tested it as much as I could by navigated through the whole app and could not find any other errors.
This can be a breaking change so it needs to be thoroughly tested, so the more eyes that takes a look the better.