Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formatting #148

Closed
wants to merge 31 commits into from
Closed

Conversation

Jerakin
Copy link
Contributor

@Jerakin Jerakin commented Feb 29, 2024

Summary

Refactor to update styling to be more in style with conventions, pep8 and such

These are used by other packages defined,
it's better to let them take care that the correct version is installed.
moving the template folder into source to indicate that it is part of the app proper
Ensure the app works if people use pip install . without the editable flag
Also adds tests to make sure it doesn't break again
it's conventional to use a uri for searching
it also makes our code clearner as we do not have to guard against a serach everywhere
@Jerakin Jerakin closed this Feb 29, 2024
@Jerakin
Copy link
Contributor Author

Jerakin commented Feb 29, 2024

Sorry was meant to be against my own fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant