Style/add ruff #149
Closed
Style/add ruff #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are used by other packages defined, it's better to let them take care that the correct version is installed.
…t doesn't exist (+4 squashed commit)
moving the template folder into source to indicate that it is part of the app proper
Ensure the app works if people use pip install . without the editable flag
Also adds tests to make sure it doesn't break again
Allowed and disallowed file names
Build multiple platforms
it's conventional to use a uri for searching it also makes our code clearner as we do not have to guard against a serach everywhere
Use uri for search
Format update
By splitting the routes up we have a clear separation on what they do, seperating rendering the page from updating the resources.
refactor: split the routes into different function
Usage is simplified by offloading the work to the manager
Simplified plugin usage
Refactor the draw plugin
This enables us to encapsulate the behaviour of the page title and content. In the future making it easier to change how it behaves.
refactor: store page title and content in a class
Shows the full full wiki
sidebar page navigation
Use the full name (including suffix) by default. This enables us to add .txt files to the wiki as well as not repeat the .md suffix.
Use suffix on file name
fix: made the navbar more inline with how other websites are doing it
|
Sorry about that forgot to change the target for the PR again. Looking into it and apparently you can't change the default repo the PRs are against, will have to detach the fork to stop this from happening. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Provide a short overview ...
Details
Context to describe changes if necessary
Checks
docs/<corresponding file>