Wiki title as variable #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linbreux
requested changes
Aug 14, 2024
src/wikmd/templates/base.html
Outdated
| @@ -39,14 +39,14 @@ | |||
| } | |||
| </style> | |||
|
|
|||
| <title>Wiki</title> | |||
| <title>{% if wiki_title %}{{ wiki_title }}{% endif %}</title> | |||
There was a problem hiding this comment.
render failed when the var was empty, but since it has has a default value now it shouldn't be a problem
src/wikmd/templates/base.html
Outdated
| </head> | ||
|
|
||
| <body> | ||
| <!-- Navbar top --> | ||
| <nav class="navbar navbar-expand-lg navbar-dark bg-dark sticky-top"> | ||
| <div class="container-fluid mx-2"> | ||
| <a class="navbar-brand" href="/">Wiki</a> | ||
| <a class="navbar-brand" href="/">{% if wiki_title %}{{ wiki_title }}{% endif %}</a> |
src/wikmd/wiki.py
Outdated
| upload_path=cfg.images_route, | ||
| image_allowed_mime=cfg.image_allowed_mime, | ||
| system=SYSTEM_SETTINGS, | ||
| wiki_title=cfg.wiki_title |
There was a problem hiding this comment.
Can't you just add it to the system settings?
There was a problem hiding this comment.
yeah that's way better, I've pushed changes
fuggla
force-pushed
the
feat-wiki-title
branch
from
ba17192 to
b362cd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes from hardcoded "Wiki" as title in head and navbar to a variable.
It would be cool to have a prefix in <title> depending on which page is displayed. E.g. "homepage | Wiki". I could have a look at figuring it out but I'm not sure what would be a clean way to implement it.
Details
Checks
docs/<corresponding file>