Multiscene – making multiple indices into one gif #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Thanks for the PR this is fairly large so it's going to take me a little bit to review. |
LindseyB
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea is to allow people to make a gif out of multiple indices.
For now this is limited to one movie, as I did not want to keep loading the subtitle file over and over again (maybe some "caching" in the future?).
The script is also reaching a certain length where I am thinking about refactoring stuff again.
I have only updated the star_wars_gif.py to still work, you can only select a single quote/index using that interactive script, though.
I believe this is getting close to what #16 is about, although as I said in the issue I am not willing to add external dependencies, especially if that would be essentially html-scraping.
I have not updated the readme yet, I am not sure it shouldn't be split into multiple documents, since it is also getting fairly sizeable now.