Bin gkernel alignment #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic! Thanks and merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align the behavior of bin and gkernel, and make it possible to easily pass bins for custom time axis resampling. Note that I could not use scipy.stats.binned_statistic for both functions because gkernel requires the usage of both the time and value axis when computing bin values, which the scipy function does not allow for. That being said, the way each function calculates bin edges should now be identical.
I considered using the same piece of code for both functions, but using the scipy code for the bin function makes it much more flexible in terms of what statistic can be calculated over the bins, which could be very valuable.