Add javadoc fixes

LinkedInAttic · Nov 5, 2013 · e198a6b · e198a6b
1 parent 2635856
commit e198a6b
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 20 deletions.
diff --git a/src/java/datafu/pig/sampling/ReservoirSample.java b/src/java/datafu/pig/sampling/ReservoirSample.java
@@ -35,9 +35,9 @@
  * a uniformly random sample of a given size.
  * 
  * <p>
- * This is similar to {@see SimpleRandomSample}, however it is guaranteed to produce
+ * This is similar to {@link SimpleRandomSample}, however it is guaranteed to produce
  * a sample of the given size.  This comes at the cost of scalability.
- * {@see SimpleRandomSample} produces a sample of the desired size with likelihood of 99.99%,
+ * {@link SimpleRandomSample} produces a sample of the desired size with likelihood of 99.99%,
  * while using less internal storage.  ReservoirSample on the other hand uses internal storage
  * with size equaling the desired sample to guarantee the exact sample size.
  * </p>

diff --git a/src/java/datafu/pig/stats/QuantileUtil.java b/src/java/datafu/pig/stats/QuantileUtil.java
@@ -18,7 +18,7 @@
 import java.util.ArrayList;
 
 /**
- * Methods used by {@see Quantile}.
+ * Methods used by {@link Quantile}.
  * 
  * @author "Matthew Hayes <mhayes@linkedin.com>"
  *

diff --git a/src/java/datafu/pig/util/Assert.java b/src/java/datafu/pig/util/Assert.java
@@ -16,17 +16,12 @@
 
 package datafu.pig.util;
 
-import java.io.IOException;
-
-import org.apache.pig.FilterFunc;
-import org.apache.pig.data.Tuple;
-
 /**
  * Assert has been renamed to AssertUDF.
  * 
  * This class is provided for backward compatibility.
  *
- * @deprecated Use {@link AssertUDF()} instead.
+ * @deprecated Use {@link AssertUDF} instead.
  */
  @Deprecated
 public class Assert extends AssertUDF

diff --git a/src/java/datafu/pig/util/Coalesce.java b/src/java/datafu/pig/util/Coalesce.java
@@ -17,15 +17,11 @@
 package datafu.pig.util;
 
 import java.io.IOException;
-import java.util.Map;
-import java.util.Properties;
 
-import org.apache.pig.EvalFunc;
 import org.apache.pig.data.DataType;
 import org.apache.pig.data.Tuple;
 import org.apache.pig.impl.logicalLayer.schema.Schema;
 import org.apache.pig.impl.logicalLayer.schema.Schema.FieldSchema;
-import org.apache.pig.impl.util.UDFContext;
 
 /**
  * Returns the first non-null value from a tuple, just like {@link <a href="http://msdn.microsoft.com/en-us/library/ms190349.aspx" target="_blank">COALESCE</a>} in SQL. 
@@ -52,7 +48,6 @@
  */
 public class Coalesce extends AliasableEvalFunc<Object>
 {
-  private String instanceName;
   private boolean strict;
 
   private static String STRICT_OPTION = "strict";

diff --git a/src/java/datafu/pig/util/In.java b/src/java/datafu/pig/util/In.java
@@ -1,16 +1,11 @@
 package datafu.pig.util;
 
-import java.io.IOException;
-
-import org.apache.pig.FilterFunc;
-import org.apache.pig.data.Tuple;
-
 /**
  * In has been renamed to InUDF.
  * 
  * This class is provided for backward compatibility.
  *
- * @deprecated Use {@link InUDF()} instead.
+ * @deprecated Use {@link InUDF} instead.
  */
  @Deprecated
 public class In extends InUDF

diff --git a/src/java/datafu/pig/util/SimpleEvalFunc.java b/src/java/datafu/pig/util/SimpleEvalFunc.java
@@ -139,6 +139,7 @@ private String _method_signature()
   @SuppressWarnings("unchecked")
   public T exec(Tuple input) throws IOException
   {
+    @SuppressWarnings("rawtypes")
     Class pvec[] = m.getParameterTypes();
 
     if (input == null || input.size() == 0)
@@ -183,6 +184,7 @@ public Schema outputSchema(Schema inputSchema)
     }
 
     // check correct number of arguments
+    @SuppressWarnings("rawtypes")
     Class parameterTypes[] = m.getParameterTypes();
     if (inputSchema.size() != parameterTypes.length) {
       throw new IllegalArgumentException(String.format("%s: got %d arguments, expected %d.",