Skip to content

Commit

Permalink
tools: be intentional about masking possible error in start-ci.sh
Browse files Browse the repository at this point in the history
Revise start-ci.sh to conform with shellcheck 0.8.0 default checks.

Refs: https://www.shellcheck.net/wiki/SC2312

PR-URL: nodejs#41284
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
Trott authored and Linkgoron committed Jan 31, 2022
1 parent 28faee8 commit b1ab18b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/actions/start-ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ for pr in "$@"; do
# Do we need to reset?
gh pr edit "$pr" --add-label "$REQUEST_CI_FAILED_LABEL"

jq -n --arg content "<details><summary>Couldn't start CI</summary><pre>$(cat output)</pre></details>" > output.json
jq -n --arg content "<details><summary>Couldn't start CI</summary><pre>$(cat output || true)</pre></details>" > output.json

gh pr comment "$pr" --body-file output.json

Expand Down

0 comments on commit b1ab18b

Please sign in to comment.