Chore: Feature/frontend install #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChTiSh
requested review from
dcpavel,
relandboyle,
bjpreston,
kinskiwu,
LucieSeidler and
AnatoliySokolov98
ChTiSh
added
frontend
relandboyle
reviewed
Mar 8, 2024
There was a problem hiding this comment.
@ChTiSh Are you able to clone and install in a fresh directory with this branch?
I'm running into a dependency issue with typedoc 0.25.11. It should be compatible with typescript 5.4.2 but...
TypeStrong/typedoc#2517
I'm able to install with typescript version 4.3.3.
relandboyle
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
@ChTiSh As per our conversation, we're committing to using JSDoc until further notice.
bjpreston
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Front end packages installation
Linkta#19
Installed with this PR: Tanstack Query(with linter), Zustand, Typescript, Manual install Next, Typedoc
For quick reference to use Zustand with typescript:
https://docs.pmnd.rs/zustand/guides/typescript#slices-pattern
For Radix, we should do incremental adoption.
Each primitive can be installed individually as needed:
https://www.radix-ui.com/primitives/docs/overview/introduction
For typedoc, we will need further configuration with tsconfig @dcpavel @AnatoliySokolov98 @LucieSeidler
https://www.npmjs.com/package/typedoc