Memory leak fix in sigma.classes.graph

The edges referenced in the edges indexes where actually not the ones stored in the sigma.classes.graph instance, but the ones given to it. Leak found by @sheymann and showed in #340 (thanks!).
Linkurious · Aug 13, 2014 · 0e2d3f8 · 0e2d3f8
1 parent b20cd14
commit 0e2d3f8
Showing 1 changed file with 27 additions and 19 deletions.
diff --git a/src/classes/sigma.classes.graph.js b/src/classes/sigma.classes.graph.js
@@ -486,27 +486,35 @@
     this.edgesArray.push(validEdge);
     this.edgesIndex[validEdge.id] = validEdge;
 
-    if (!this.inNeighborsIndex[edge.target][edge.source])
-      this.inNeighborsIndex[edge.target][edge.source] = Object.create(null);
-    this.inNeighborsIndex[edge.target][edge.source][edge.id] = edge;
-
-    if (!this.outNeighborsIndex[edge.source][edge.target])
-      this.outNeighborsIndex[edge.source][edge.target] = Object.create(null);
-    this.outNeighborsIndex[edge.source][edge.target][edge.id] = edge;
-
-    if (!this.allNeighborsIndex[edge.source][edge.target])
-      this.allNeighborsIndex[edge.source][edge.target] = Object.create(null);
-    this.allNeighborsIndex[edge.source][edge.target][edge.id] = edge;
-
-    if (!this.allNeighborsIndex[edge.target][edge.source])
-      this.allNeighborsIndex[edge.target][edge.source] = Object.create(null);
-    this.allNeighborsIndex[edge.target][edge.source][edge.id] = edge;
+    if (!this.inNeighborsIndex[validEdge.target][validEdge.source])
+      this.inNeighborsIndex[validEdge.target][validEdge.source] =
+        Object.create(null);
+    this.inNeighborsIndex[validEdge.target][validEdge.source][validEdge.id] =
+      validEdge;
+
+    if (!this.outNeighborsIndex[validEdge.source][validEdge.target])
+      this.outNeighborsIndex[validEdge.source][validEdge.target] =
+        Object.create(null);
+    this.outNeighborsIndex[validEdge.source][validEdge.target][validEdge.id] =
+      validEdge;
+
+    if (!this.allNeighborsIndex[validEdge.source][validEdge.target])
+      this.allNeighborsIndex[validEdge.source][validEdge.target] =
+        Object.create(null);
+    this.allNeighborsIndex[validEdge.source][validEdge.target][validEdge.id] =
+      validEdge;
+
+    if (!this.allNeighborsIndex[validEdge.target][validEdge.source])
+      this.allNeighborsIndex[validEdge.target][validEdge.source] =
+        Object.create(null);
+    this.allNeighborsIndex[validEdge.target][validEdge.source][validEdge.id] =
+      validEdge;
 
     // Keep counts up to date:
-    this.inNeighborsCount[edge.target]++;
-    this.outNeighborsCount[edge.source]++;
-    this.allNeighborsCount[edge.target]++;
-    this.allNeighborsCount[edge.source]++;
+    this.inNeighborsCount[validEdge.target]++;
+    this.outNeighborsCount[validEdge.source]++;
+    this.allNeighborsCount[validEdge.target]++;
+    this.allNeighborsCount[validEdge.source]++;
 
     return this;
   });