Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS/macOS] Fix for Xcode 12.5 #76

Closed
wants to merge 4 commits into from
Closed

[iOS/macOS] Fix for Xcode 12.5 #76

wants to merge 4 commits into from

Conversation

kyle-seongwoo-jun
Copy link

Problem

Crash on native (iOS, macOS) when callbackURLScheme is an entire URL like foo://bar.

References: auth0/react-native-auth0#360, auth0/react-native-auth0#369

@LinusU
Copy link
Owner

LinusU commented Jul 29, 2021

Would you mind explaining a bit more why this is needed? The argument is called callbackURLScheme so I think it's implied that you should pass a scheme and not an entire url? 🤔

Could we instead detect if an entire url is passed and raise an appropriate error? 🤔

@kyle-seongwoo-jun
Copy link
Author

@LinusU I just update the code to validate the scheme in authenticate().

Please check it out. Thank you.

@LinusU
Copy link
Owner

LinusU commented Sep 7, 2021

Hey @kyle-seongwoo-jun,

  1. It seems like you copied some code from the dart core project, have you looked into the licensing/copyright implications of doing so?
  2. Could we keep the schema-validator in a separate file?

@LinusU
Copy link
Owner

LinusU commented Nov 1, 2022

Thanks for taking the time to submit this PR! 🙏

Since the last comments wasn't addressed I implemented this using a regex instead: 4f89925

Happy hacking!

@LinusU LinusU closed this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants