Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor count_names() for improved clarity #2788

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

havardAasen
Copy link
Contributor

Simplified the logic by changing to a while loop and removing a variable.

Simplified the logic by changing to a while loop and removing a
variable.
@andypugh
Copy link
Collaborator

I think that your code continues an error in the existing code, that the limit may not be MAX_IO for all cases where the function is called. This isn't currrently a problem. https://github.com/LinuxCNC/linuxcnc/blob/2.9/src/emc/motion/emcmotcfg.h#L33
But it feels like the function should be passed the relevant parameter rather than the local MAX_IO.

@andypugh andypugh merged commit 1db5638 into LinuxCNC:master Dec 15, 2023
11 checks passed
@havardAasen havardAasen deleted the refactor-count_names branch December 16, 2023 07:16
@havardAasen
Copy link
Contributor Author

havardAasen commented Dec 16, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants