issue #3217 addressed review comments

Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
LinuxForHealth · Feb 4, 2022 · 7653e52 · 7653e52
1 parent 56ed30e
commit 7653e52
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 2 deletions.
diff --git a/fhir-persistence-schema/docs/SchemaToolUsageGuide.md b/fhir-persistence-schema/docs/SchemaToolUsageGuide.md
@@ -551,6 +551,17 @@ java -jar ./fhir-persistence-schema-${VERSION}-cli.jar \
 --show-db-size-detail
 ```
 
+**Note:** For Db2, you must also include the desired tenant name, for example:
+
+``` shell
+java -jar ./fhir-persistence-schema-${VERSION}-cli.jar \
+--prop-file fhiradmin.properties \
+--db-type db2 \
+--schema-name FHIRDATA \
+--tenant-name MY_TENANT_NAME \
+--show-db-size
+```
+
 The detail rows are tab-separated, making it easy to load the data into a spreadsheet for further analysis.
 
 **Notes:**

diff --git a/fhir-persistence-schema/src/main/java/com/ibm/fhir/schema/size/FHIRDbResourceSize.java b/fhir-persistence-schema/src/main/java/com/ibm/fhir/schema/size/FHIRDbResourceSize.java
@@ -10,7 +10,7 @@
 import java.util.Map;
 
 /**
- * Schema objects related to this resource
+ * Schema objects related to this resource type
  */
 public class FHIRDbResourceSize {
 

diff --git a/fhir-persistence-schema/src/main/java/com/ibm/fhir/schema/size/ISizeReport.java b/fhir-persistence-schema/src/main/java/com/ibm/fhir/schema/size/ISizeReport.java
@@ -13,7 +13,7 @@ public interface ISizeReport {
 
     /**
      * Render a report using the data from the given model
-     * @param os
+     * @param model
      */
     public void render(FHIRDbSizeModel model);
 

diff --git a/fhir-persistence-schema/src/main/java/com/ibm/fhir/schema/size/PostgresSizeCollector.java b/fhir-persistence-schema/src/main/java/com/ibm/fhir/schema/size/PostgresSizeCollector.java
@@ -85,6 +85,7 @@ private void collectTableInfo(String schemaName, Connection connection, IDatabas
             throw translator.translate(x);
         }
     }
+
     private void collectIndexInfo(String schemaName, Connection connection, IDatabaseTranslator translator) {
         final String SQL = ""
                 + "    SELECT t.tablename,"