Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No schema files #159

Closed
kaklyugin opened this issue Sep 27, 2019 · 11 comments
Closed

No schema files #159

kaklyugin opened this issue Sep 27, 2019 · 11 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@kaklyugin
Copy link

Hi, guys!
Looks, there're no schemaddl and createDB.sh files.
( Probably i did something wrong. I'vw insalled FHIR server, it works with DERBY, but i cannot connect it to DB2 , because there's no database schema)

Steps to reproduce the behavior:

  1. Compile source code
  2. Deploy to C:\liberty-runtime
  3. Go to C:\liberty-runtime\wlp\bin
  4. No <WLP_HOME>/fhir/bin/schemaddl file
  5. No <WLP_HOME>/fhir/bin/createDB.sh
  6. No fhir.properties file ( as far, as I understand, it is needed to generate schema)

Expected behavior
Files exist.

@kaklyugin kaklyugin added the bug Something isn't working label Sep 27, 2019
@prb112
Copy link
Contributor

prb112 commented Sep 27, 2019

@lmsurpre
Copy link
Member

lmsurpre commented Sep 27, 2019

In the meantime we do have https://github.com/IBM/FHIR/blob/master/docs/DB2OnCloudSetup.md which covers setting up Db2 on Cloud...probably you could use that as we update the User Guide (which is more of an Administrators guide). Pardon our dust...

UPDATE: the guide has moved to https://github.com/IBM/FHIR/blob/master/docs/src/pages/guides/DB2OnCloudSetup.md

@lmsurpre lmsurpre added the documentation Improvements or additions to documentation label Oct 30, 2019
prb112 added a commit that referenced this issue Nov 6, 2019
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112
Copy link
Contributor

prb112 commented Nov 6, 2019

PR #371

@prb112
Copy link
Contributor

prb112 commented Nov 6, 2019

The docs are updated, and the schema is posted to docs/schema. along with a SimpleSchemaPrinter updated to output the latest.

@prb112 prb112 self-assigned this Nov 6, 2019
@lmsurpre
Copy link
Member

lmsurpre commented Nov 7, 2019

I'm not sure that we want to put the DDL into our docs...it would be something we'd really need to commit to keeping up-to-date. We'd need to be very diligent about updating docs with every schema update.

I think this issue was opened more because the User Guide was stale and pointing at our old fhir-schemaddl project (<WLP_HOME>/fhir/bin/schemaddl and <WLP_HOME>/fhir/bin/createDB.sh) and so I think the "fix" is to document how to use the fhir-persistence-schema project to accomplish these tasks. https://github.com/IBM/FHIR/blob/master/docs/src/pages/guides/DB2OnCloudSetup.md is close, but it doesn't cover the initial database creation steps since those aren't needed with Db2 on Cloud.
UPDATE: actually, after reading through it, it doesn't even cover how to apply our schema at all.

I think we just need to document how to

  1. create the database (we used to have shell script for this but its really not specific to our project); then
  2. how to use fhir-persistence-schema to create and manage the schema. Everything we have on this today is at https://github.com/IBM/FHIR/tree/master/fhir-persistence-schema

@prb112
Copy link
Contributor

prb112 commented Nov 7, 2019

I really see fhir-persistence-schema as insufficient for project consumers. There are two roles - database administrators and application administrators. The creation of a schema using a third party tool is uncommon for third parties.

There needs to be a reviewable artifact or a method to create the artifact as-is. It's highly unlikely that the same people using the code are always administering the database.

I'm OK with a how to.

prb112 added a commit that referenced this issue Nov 7, 2019
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue Nov 7, 2019
Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
@prb112
Copy link
Contributor

prb112 commented Nov 7, 2019

Discussed with Lee in a code review and design discussion.
We both agree how-to docs are the right way to go, as the tag is kept up to date.

@prb112
Copy link
Contributor

prb112 commented Nov 7, 2019

QA complete. #380 is a follow on to add dryrun functionality to the command structure.

@prb112 prb112 closed this as completed Nov 7, 2019
prb112 added a commit that referenced this issue Nov 7, 2019
@prb112 prb112 reopened this Nov 7, 2019
@prb112
Copy link
Contributor

prb112 commented Nov 7, 2019

Discussed with team. @kaklyugin we'd be interested in your feedback.
We do plan on adding a dryrun behavior.

We'll close this at end of Sprint 4 (if no feedback). [Nov 25]

@prb112
Copy link
Contributor

prb112 commented Nov 22, 2019

Hi @kaklyugin please let us know your thoughts.

@prb112 prb112 closed this as completed Nov 25, 2019
@prb112
Copy link
Contributor

prb112 commented Nov 25, 2019

Marked as close at the end of Sprint 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants