Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a more efficient way to handle closure operation requests that have more than one coding #2162

Closed
JohnTimm opened this issue Mar 27, 2021 · 2 comments
Assignees

Comments

@JohnTimm
Copy link
Collaborator

JohnTimm commented Mar 27, 2021

One step towards a more efficient way to handle more than one coding in a closure operation request is to add a closure method signature to the FHIRTermServiceProvider SPI that supports multiple codes. For example:

Map<Code, Set<Concept>> closure(CodeSystem codeSystem, Set<Code> codes);

and a closure method signature to FHIRTermService:

Map<Coding, Set<Concept>> closure(Set<Coding> codings);

See: https://chat.fhir.org/#narrow/stream/179202-terminology/topic/ibm.20as.20a.20fhir.20terminology.20server for more info

@JohnTimm JohnTimm self-assigned this Mar 27, 2021
JohnTimm added a commit that referenced this issue Apr 6, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm added this to the Sprint 2021-05 milestone Apr 6, 2021
JohnTimm added a commit that referenced this issue Apr 6, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 6, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 6, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 6, 2021
Issue #2162 - introduce a new closure method signature
JohnTimm added a commit that referenced this issue Apr 7, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 7, 2021
Issue #2162 - introduce hasConcepts method
JohnTimm added a commit that referenced this issue Apr 7, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 8, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 8, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 8, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 8, 2021
* Issue #2162 - miscellaneous updates

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2162 - minor tweaks to naming / javadoc

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2162 - renamed unit test method

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>

* Issue #2162 - change "mapper" to "function"

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@lmsurpre
Copy link
Member

lmsurpre commented Apr 12, 2021

I confirm that the new closure variants (closure(Set<Coding> codings) and closure(CodeSystem codeSystem, Set<Code> codes)) have been added to FHIRTermService.
closure(Set<Coding> codings) is covered by a unit test and is now used by the ClosureOperation.

closure(CodeSystem codeSystem, Set<Code> codes) doesn't seem to be covered by any tests, but its a one-line implementation the delegates to closure(CodeSystem codeSystem, Set<Code> codes) and I confirmed that both our registry-based and graph-based implementations for that are covered by FHIRTermServiceProviderTest.testClosure2().

One minor thing I noticed is that one variant of the closure method (Set<Concept> closure(CodeSystem codeSystem, Code code)) is missing javadoc, so that might be good to add.

JohnTimm added a commit that referenced this issue Apr 12, 2021
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
JohnTimm added a commit that referenced this issue Apr 12, 2021
…2238)

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@lmsurpre
Copy link
Member

the javadoc comment is now added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants