-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token search with case-insensitive code system failing when common_token_value_id for system+code previously stored with case-sensitive code #2308
Comments
This only happens if there is already data in the DB, with a new Derby DB this does not reproduce. |
If a token value which specifies a case-insensitive code system and a code which contains uppercase characters has been indexed prior to changes made for issue #1551 and stored in the common_token_values table, then on a subsequent resource creation and search specifying the same system+code after the 1551 changes, the resource will not get returned as a match, even though it should. This is due to a bug in how the common_token_value_id is being retrieved - it should be trying to retrieve based on the normalized code value for a case-insensitive code system, but it is using the code value unmodified. This results in the wrong common_token_value_id being used in the search query, thus no match. |
Signed-off-by: Mike Schroeder <mschroed@us.ibm.com>
Signed-off-by: Mike Schroeder <mschroed@us.ibm.com>
Issue #2308 - fix retrieval of commonTokenValueId from cache
Ran the following to confirm behavior:
|
In my local Eclipse environment, pulled the latest changes to FHIR main and rebuilt.
Ran FHIR Integration Tests ... 9 of them failed.
All were specific to token search where you specify both system and code and the system is case-insensitive and the code does not match its normalized code value (i.e. code contains uppercase characters)
Expected all tests to pass.
The text was updated successfully, but these errors were encountered: