Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBM FHIR Server CapabilityStatement is invalid #2436

Closed
lmsurpre opened this issue May 26, 2021 · 1 comment
Closed

IBM FHIR Server CapabilityStatement is invalid #2436

lmsurpre opened this issue May 26, 2021 · 1 comment
Assignees
@prb112
Labels
bug Something isn't working P1 Priority 1 - Must Have specification terminology
Milestone
Sprint 2021-07

Comments

@lmsurpre
Copy link
Member

lmsurpre commented May 26, 2021 •
edited by prb112
Loading

Describe the bug

Validation of response body against profile 'http://hl7.org/fhir/StructureDefinition/CapabilityStatement' by FHIR 
specification's Validation Engine produced the following results:
ERROR: If kind = instance, implementation must be present and software may be present [(kind != 'instance') or 
implementation.exists()]. Location: CapabilityStatement (line 1, col 2).

Environment
4.8.x

To Reproduce
Steps to reproduce the behavior:

  1. GET [base]/metadata https://localhost:9443/fhir-server/api/v4/metadata?mode=terminology
  2. validate it

Expected behavior
the /metadata endpoint should serve a valid CapabilityStatement

Additional context
In 4fb5d81 we updated the CapabilityStatement to kind...we just failed to account for this extra constraint.

We should run our TerminologyStatement through a validator too to make sure that one is valid as well.
@lmsurpre lmsurpre added the bug Something isn't working label May 26, 2021
@lmsurpre lmsurpre added this to the Sprint 2021-07 milestone May 26, 2021
@lmsurpre lmsurpre added the P1 Priority 1 - Must Have label May 26, 2021
@prb112 prb112 self-assigned this May 27, 2021
@prb112 prb112 changed the title FHIR Server CapabilityStatement is invalid IBM FHIR Server CapabilityStatement is invalid May 27, 2021
prb112 added a commit that referenced this issue May 27, 2021
@prb112
IBM FHIR Server CapabilityStatement is invalid #2436
08a0c9f 
- Add implementation for the various Capabilities statements
- Add FHIRPath validation to IT tests
- Add configuration property for URL

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
prb112 added a commit that referenced this issue Jun 1, 2021
@prb112
Merge pull request #2439 from IBM/issue-2436
cc6333a 
IBM FHIR Server CapabilityStatement is invalid #2436
lmsurpre added a commit that referenced this issue Jun 4, 2021
@lmsurpre
issue #2436 - validate the metadata response in e2e tests
6dbc97e 
For both the CapabilityStatement and the TerminologyStatement.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre
Copy link
Member Author

lmsurpre commented Jun 4, 2021

I ran both the updated CapabilityStatement and the MetadataStatement through our validator and both are now passing.
Additionally, I opened #2467 so that our CI runs will always run these through our validator going forward.

@lmsurpre lmsurpre closed this as completed Jun 4, 2021
JohnTimm pushed a commit that referenced this issue Jun 4, 2021
@lmsurpre
issue #2436 - validate the metadata response in e2e tests (#2467)
c185a79 
For both the CapabilityStatement and the TerminologyStatement.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
tbieste pushed a commit that referenced this issue Jun 9, 2021
@prb112 @tbieste
IBM FHIR Server CapabilityStatement is invalid #2436
d47474d 
- Add implementation for the various Capabilities statements
- Add FHIRPath validation to IT tests
- Add configuration property for URL

Signed-off-by: Paul Bastide <pbastide@us.ibm.com>
tbieste pushed a commit that referenced this issue Jun 9, 2021
@prb112 @tbieste
Merge pull request #2439 from IBM/issue-2436
fcfa71c 
IBM FHIR Server CapabilityStatement is invalid #2436
tbieste pushed a commit that referenced this issue Jun 9, 2021
@lmsurpre @tbieste
issue #2436 - validate the metadata response in e2e tests (#2467)
a8abc0a 
For both the CapabilityStatement and the TerminologyStatement.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prb112 prb112

Labels
bug Something isn't working P1 Priority 1 - Must Have specification terminology
Projects
None yet
Milestone
Sprint 2021-07
Development

No branches or pull requests
2 participants
@prb112 @lmsurpre