Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fhir-bucket reindex driver must support force option #3731

Closed
punktilious opened this issue Jun 22, 2022 · 1 comment
Closed

fhir-bucket reindex driver must support force option #3731

punktilious opened this issue Jun 22, 2022 · 1 comment
Assignees
Labels
bug Something isn't working P1 Priority 1 - Must Have

Comments

@punktilious
Copy link
Collaborator

punktilious commented Jun 22, 2022

Describe the bug
When reindexing, the server checks the hash of the extracted parameter values with the value currently stored in the database. If they match, the reindex is skipped. Unfortunately this means that reindex is skipped when we've changed the parameter storage schema (as we did for schema V0027). The reindex operation supports a "force" parameter which overrides the hash check. However, this option currently isn't passed when using fhir-bucket to drive the reindex.

Environment
Which version of IBM FHIR Server? 5.0.0-SNAPSHOT

To Reproduce
Steps to reproduce the behavior:

  1. Install 4.11.1
  2. Load data
  3. Perform a search using a reference field
  4. Upgrade to 5.0.0 (schema V0028)
  5. Run reindex
  6. See searches using references fail to retrieve data

Expected behavior
fhir-bucket needs to support a --reindex-force option and if true, will pass the force parameter value in the reindex request.

The fhir-bucket README.md should also be updated with the new option.

Additional context
We may also want to consider including the current schema version in the parameter hash calculation. This would make the reindex automatic when we change the schema version. But this a little more complicated, because not all schema changes require a reindex.

@punktilious punktilious added the bug Something isn't working label Jun 22, 2022
@punktilious punktilious self-assigned this Jun 22, 2022
@punktilious punktilious added the P1 Priority 1 - Must Have label Jun 22, 2022
punktilious added a commit that referenced this issue Jun 22, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Jun 22, 2022
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@lmsurpre
Copy link
Member

lmsurpre commented Aug 4, 2022

Robin has been using this a lot and we see the log output as proof

@lmsurpre lmsurpre closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1 Priority 1 - Must Have
Projects
None yet
Development

No branches or pull requests

2 participants