Out of Date File in fhir-audit #4
Assignees
Comments
|
The file is removed in the latest commits to |
|
The file removal has been verified. |
lmsurpre
added a commit
that referenced
this issue
Feb 5, 2020
1. Added FHIRPathSpecTest for executing the spec-provided FHIRPath Patch test cases. I needed to tweak the test file to work around our strict interpretation of `ele-1` which makes empty resources invalid. I also removed a single fhirpath patch operation from the `Full Resource` testcase...we currently cannot handle replace of DomainResource.text.div 2. Added logic to throw UnsupportedOperationException for patches with nested part values and added corresponding skip logic from the test 3. Added skip logic for 2 other test cases, both with `mode=forwards` * `Delete Nested Primitive #2`: this test expects that the server will automatically remove a parent elements when the last element from within one is removed. We don't do that. * `Reorder List #4`: on this one, I disagree with the expected output 4. Found and fixed an issue with the original implementation; patch values for code subtypes come is as basic Code types whereas the setters expect a subtype, so I needed to add logic to convert the Code to the appropriate subtype before calling any setters. Finally, I added the FHIR mimetypes to the patchFormat element of our CapabilityStatement to indicate that we now support FHIRPath patch. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Feb 5, 2020
1. Added FHIRPathSpecTest for executing the spec-provided FHIRPath Patch test cases. I needed to tweak the test file to work around our strict interpretation of `ele-1` which makes empty resources invalid. I also removed a single fhirpath patch operation from the `Full Resource` testcase...we currently cannot handle replace of DomainResource.text.div 2. Added logic to throw UnsupportedOperationException for patches with nested part values and added corresponding skip logic from the test 3. Added skip logic for 2 other test cases, both with `mode=forwards` * `Delete Nested Primitive #2`: this test expects that the server will automatically remove a parent elements when the last element from within one is removed. We don't do that. * `Reorder List #4`: on this one, I disagree with the expected output 4. Found and fixed an issue with the original implementation; patch values for code subtypes come is as basic Code types whereas the setters expect a subtype, so I needed to add logic to convert the Code to the appropriate subtype before calling any setters. Finally, I added the FHIR mimetypes to the patchFormat element of our CapabilityStatement to indicate that we now support FHIRPath patch. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
added a commit
that referenced
this issue
Feb 5, 2020
1. Added FHIRPathSpecTest for executing the spec-provided FHIRPath Patch test cases. I needed to tweak the test file to work around our strict interpretation of `ele-1` which makes empty resources invalid. I also removed a single fhirpath patch operation from the `Full Resource` testcase...we currently cannot handle replace of DomainResource.text.div 2. Added logic to throw UnsupportedOperationException for patches with nested part values and added corresponding skip logic from the test 3. Added skip logic for 2 other test cases, both with `mode=forwards` * `Delete Nested Primitive #2`: this test expects that the server will automatically remove a parent elements when the last element from within one is removed. We don't do that. * `Reorder List #4`: on this one, I disagree with the expected output 4. Found and fixed an issue with the original implementation; patch values for code subtypes come is as basic Code types whereas the setters expect a subtype, so I needed to add logic to convert the Code to the appropriate subtype before calling any setters. Finally, I added the FHIR mimetypes to the patchFormat element of our CapabilityStatement to indicate that we now support FHIRPath patch. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During a review of the codebase on August 30, 2019, we identified an out-of-date and unused file with
keyivused for ondisk encryption of logs. The file isfhir-audit/src/main/resources/config.propertiesThere are no running instances which use the library that use this configuration file specific to audit.
There is no compilable code which uses the config.properties.
The team has opted to remove the unused file.
The text was updated successfully, but these errors were encountered: