Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converge onto a single docker image #837

Closed
prb112 opened this issue Mar 23, 2020 · 1 comment
Closed

converge onto a single docker image #837

prb112 opened this issue Mar 23, 2020 · 1 comment
Assignees
@prb112 @lmsurpre
Labels
automation automation
Milestone
Sprint 11

Comments

@prb112
Copy link
Contributor

prb112 commented Mar 23, 2020

converge onto a single docker image

Currently we have a debian and a UBI version.
Converge down to one image.

Related #814
@prb112 prb112 added the automation automation label Mar 23, 2020
@lmsurpre lmsurpre mentioned this issue Mar 30, 2020
Closed
@lmsurpre
Copy link
Member

lmsurpre commented Apr 6, 2020

I think its mostly unrelated to this one, but I notice that the UBI image prints this warning during startup:

[AUDIT   ] CWWKG0102I: Found conflicting settings for defaultKeyStore instance of keyStore configuration.
  Property password has conflicting values:
    Secure value is set in file:/opt/ol/wlp/usr/servers/fhir-server/configDropins/defaults/keystore.xml.
    Secure value is set in file:/opt/ol/wlp/usr/servers/fhir-server/server.xml.
  Property password will be set to the value defined in file:/opt/ol/wlp/usr/servers/fhir-server/server.xml.

lmsurpre added a commit that referenced this issue Apr 7, 2020
@lmsurpre
issue #837 - moved docker-compose env and all related scripts to build
c9c803b 
Previously, the CI pipeline used a strange mix of scripts from `build`
and `fhir-install`.
Now there is a single Dockerfile in fhir-install and the variants used
by our CI pipeline are nicely contained under the build directory.

I performed a lot of cleanup / script normalization in the process.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 7, 2020
@lmsurpre
issue #837 - moved docker-compose env and all related scripts to build
68928ed 
Previously, the CI pipeline used a strange mix of scripts from `build`
and `fhir-install`.
Now there is a single Dockerfile in fhir-install and the variants used
by our CI pipeline are nicely contained under the build directory.

I performed a lot of cleanup / script normalization in the process.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 7, 2020
@lmsurpre
issue #837 - moved docker-compose env and all related scripts to build
b92d3ce 
Previously, the CI pipeline used a strange mix of scripts from `build`
and `fhir-install`.
Now there is a single Dockerfile in fhir-install and the variants used
by our CI pipeline are nicely contained under the build directory.

I performed a lot of cleanup / script normalization in the process.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
issue #837 - moved docker-compose env and all related scripts to build
19fcdb2 
Previously, the CI pipeline used a strange mix of scripts from `build`
and `fhir-install`.
Now there is a single Dockerfile in fhir-install and the variants used
by our CI pipeline are nicely contained under the build directory.

I performed a lot of cleanup / script normalization in the process.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
issue #837 - moved docker-compose env and all related scripts to build
6a982c8 
Previously, the CI pipeline used a strange mix of scripts from `build`
and `fhir-install`.
Now there is a single Dockerfile in fhir-install and the variants used
by our CI pipeline are nicely contained under the build directory.

I performed a lot of cleanup / script normalization in the process.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
issue #837 - moved docker-compose env and all related scripts to build
d5c9811 
Previously, the CI pipeline used a strange mix of scripts from `build`
and `fhir-install`.
Now there is a single Dockerfile in fhir-install and the variants used
by our CI pipeline are nicely contained under the build directory.

I performed a lot of cleanup / script normalization in the process.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
issue #837 - moved docker-compose env and all related scripts to build
e1eba4a 
Previously, the CI pipeline used a strange mix of scripts from `build`
and `fhir-install`.
Now there is a single Dockerfile in fhir-install and the variants used
by our CI pipeline are nicely contained under the build directory.

I performed a lot of cleanup / script normalization in the process.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
issue #837 - consolidate down to a single fhir-server docker image
80e9cb4 
1. Added dockerfile-maven-plugin to fhir-install; now it builds the
`ibmcom/ibm-fhir-server` docker image as part of the "install" phase and
pushes it to a registry as part of the "deploy" phase (config pending)

2. Removed build/docker/liberty/Dockerfile; renamed the `liberty` dir to
`fhir-server`, moved the config and userlib dirs under a child directory
named "volumes", and bind mounted those volumes from the fhir-server
service defined in docker-compose.yml

3. Removed copy-dependencies.sh; now `pre-integration-test.sh` just
copies the dependencies directly to the target ($SIT) directory, so that
only the dockerized integration scripts actually use the build/docker
directory

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
issue #837 - consolidate down to a single fhir-server docker image
38889a3 
1. Added dockerfile-maven-plugin to fhir-install; now it builds the
`ibmcom/ibm-fhir-server` docker image as part of the "install" phase and
pushes it to a registry as part of the "deploy" phase (config pending)

2. Removed build/docker/liberty/Dockerfile; renamed the `liberty` dir to
`fhir-server`, moved the config and userlib dirs under a child directory
named "volumes", and bind mounted those volumes from the fhir-server
service defined in docker-compose.yml

3. Removed copy-dependencies.sh; now `pre-integration-test.sh` just
copies the dependencies directly to the target ($SIT) directory, so that
only the dockerized integration scripts actually use the build/docker
directory

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
issue #837 - consolidate down to a single fhir-server docker image
44e980f 
1. Added dockerfile-maven-plugin to fhir-install; now it builds the
`ibmcom/ibm-fhir-server` docker image as part of the "install" phase and
pushes it to a registry as part of the "deploy" phase (config pending)

2. Removed build/docker/liberty/Dockerfile; renamed the `liberty` dir to
`fhir-server`, moved the config and userlib dirs under a child directory
named "volumes", and bind mounted those volumes from the fhir-server
service defined in docker-compose.yml

3. Removed copy-dependencies.sh; now `pre-integration-test.sh` just
copies the dependencies directly to the target ($SIT) directory, so that
only the dockerized integration scripts actually use the build/docker
directory

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
issue #837 - consolidate down to a single fhir-server docker image
8544d92 
1. Added dockerfile-maven-plugin to fhir-install; now it builds the
`ibmcom/ibm-fhir-server` docker image as part of the "install" phase and
pushes it to a registry as part of the "deploy" phase (config pending)

2. Removed build/docker/liberty/Dockerfile; renamed the `liberty` dir to
`fhir-server`, moved the config and userlib dirs under a child directory
named "volumes", and bind mounted those volumes from the fhir-server
service defined in docker-compose.yml

3. Removed copy-dependencies.sh; now `pre-integration-test.sh` just
copies the dependencies directly to the target ($SIT) directory, so that
only the dockerized integration scripts actually use the build/docker
directory

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
issue #837 - consolidate down to a single fhir-server docker image
43fb8e1 
1. Added dockerfile-maven-plugin to fhir-install; now it builds the
`ibmcom/ibm-fhir-server` docker image as part of the "install" phase and
pushes it to a registry as part of the "deploy" phase (config pending)

2. Removed build/docker/liberty/Dockerfile; renamed the `liberty` dir to
`fhir-server`, moved the config and userlib dirs under a child directory
named "volumes", and bind mounted those volumes from the fhir-server
service defined in docker-compose.yml

3. Removed copy-dependencies.sh; now `pre-integration-test.sh` just
copies the dependencies directly to the target ($SIT) directory, so that
only the dockerized integration scripts actually use the build/docker
directory

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
issue #837 - consolidate down to a single fhir-server docker image
c93857e 
1. Added dockerfile-maven-plugin to fhir-install; now it builds the
`ibmcom/ibm-fhir-server` docker image as part of the "install" phase and
pushes it to a registry as part of the "deploy" phase (config pending)

2. Removed build/docker/liberty/Dockerfile; renamed the `liberty` dir to
`fhir-server`, moved the config and userlib dirs under a child directory
named "volumes", and bind mounted those volumes from the fhir-server
service defined in docker-compose.yml

3. Removed copy-dependencies.sh; now `pre-integration-test.sh` just
copies the dependencies directly to the target ($SIT) directory, so that
only the dockerized integration scripts actually use the build/docker
directory

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
issue #837 - consolidate down to a single fhir-server docker image
9629832 
1. Added dockerfile-maven-plugin to fhir-install; now it builds the
`ibmcom/ibm-fhir-server` docker image as part of the "install" phase and
pushes it to a registry as part of the "deploy" phase (config pending)

2. Removed build/docker/liberty/Dockerfile; renamed the `liberty` dir to
`fhir-server`, moved the config and userlib dirs under a child directory
named "volumes", and bind mounted those volumes from the fhir-server
service defined in docker-compose.yml

3. Removed copy-dependencies.sh; now `pre-integration-test.sh` just
copies the dependencies directly to the target ($SIT) directory, so that
only the dockerized integration scripts actually use the build/docker
directory

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
issue #837 - consolidate down to a single fhir-server docker image
435dca9 
1. Added dockerfile-maven-plugin to fhir-install; now it builds the
`ibmcom/ibm-fhir-server` docker image as part of the "install" phase and
pushes it to a registry as part of the "deploy" phase (config pending)

2. Removed build/docker/liberty/Dockerfile; renamed the `liberty` dir to
`fhir-server`, moved the config and userlib dirs under a child directory
named "volumes", and bind mounted those volumes from the fhir-server
service defined in docker-compose.yml

3. Removed copy-dependencies.sh; now `pre-integration-test.sh` just
copies the dependencies directly to the target ($SIT) directory, so that
only the dockerized integration scripts actually use the build/docker
directory

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Apr 8, 2020
@lmsurpre
Merge pull request #907 from IBM/issue-649
d9a1dcb 
issue #837 - consolidate to a single fhir-server docker image
@lmsurpre lmsurpre added this to the Sprint 11 milestone Apr 8, 2020
@lmsurpre lmsurpre closed this as completed Apr 8, 2020
@lmsurpre lmsurpre mentioned this issue Apr 13, 2020
Closed
ccorley pushed a commit to ccorley/FHIR that referenced this issue Apr 21, 2020
@lmsurpre
issue LinuxForHealth#837 - moved docker-compose env and all related s…
6672974 
…cripts to build

Previously, the CI pipeline used a strange mix of scripts from `build`
and `fhir-install`.
Now there is a single Dockerfile in fhir-install and the variants used
by our CI pipeline are nicely contained under the build directory.

I performed a lot of cleanup / script normalization in the process.

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Signed-off-by: ccorley <ccorley@us.ibm.com>
ccorley pushed a commit to ccorley/FHIR that referenced this issue Apr 21, 2020
@lmsurpre
issue LinuxForHealth#837 - consolidate down to a single fhir-server d…
27d4316 
…ocker image

1. Added dockerfile-maven-plugin to fhir-install; now it builds the
`ibmcom/ibm-fhir-server` docker image as part of the "install" phase and
pushes it to a registry as part of the "deploy" phase (config pending)

2. Removed build/docker/liberty/Dockerfile; renamed the `liberty` dir to
`fhir-server`, moved the config and userlib dirs under a child directory
named "volumes", and bind mounted those volumes from the fhir-server
service defined in docker-compose.yml

3. Removed copy-dependencies.sh; now `pre-integration-test.sh` just
copies the dependencies directly to the target ($SIT) directory, so that
only the dockerized integration scripts actually use the build/docker
directory

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Signed-off-by: ccorley <ccorley@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prb112 prb112

@lmsurpre lmsurpre

Labels
automation automation
Projects
None yet
Milestone
Sprint 11
Development

No branches or pull requests
2 participants
@prb112 @lmsurpre