Update the search configuration to reflect new config and reindex #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the docs to reflect that `fhirServer/searchParameterFilter` has been replaced with `fhirServer/resources/<resourceType>/searchParameters`. We should probably add more documentation to explain `fhirServer/resources/<resourceType>/searchIncludes`, `fhirServer/resources/<resourceType>/searchRevIncludes`, and `fhirServer/resources/<resourceType>/searchParameterCombinations`, but for now I just wanted to make sure the stale content was cleaned up. I also added a section on using the new `$reindex` operation. Note that, rather than update them, I removed some examples and the description of the algorithm to reduce the burden of maintenance. Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
lmsurpre
commented
Nov 19, 2020
prb112
reviewed
Nov 19, 2020
prb112
reviewed
Nov 19, 2020
prb112
reviewed
Nov 19, 2020
prb112
reviewed
Nov 19, 2020
| -jar "${JAR}" \ | ||
| --db-type postgresql \ | ||
| --fhir-properties fhir.properties \ | ||
| --tenant-name "YOUR-TENANT-NAME" \ |
There was a problem hiding this comment.
is tenant-name actually used with postgres?
There was a problem hiding this comment.
I don't think it is, but I copied these argument right from what @punktilious put in our 4.5.0 release notes. I know we have #1640 for cleaning up the arguments needed by this utility, so hopefully we can clean up this doc as part of that.
|
Left minor comments |
tbieste
reviewed
Nov 19, 2020
tbieste
reviewed
Nov 19, 2020
tbieste
reviewed
Nov 19, 2020
tbieste
reviewed
Nov 19, 2020
| } | ||
| }, | ||
| "Patient": { |
There was a problem hiding this comment.
Suggest having on of these resource types have "*": "*" for example.
There was a problem hiding this comment.
Since leaving out searchParameters entirely is equivalent to having a single entry with "*": "*", I don't think it should be common to need "*": "*".
I do cover the scenario where "*": "*" is useful below (line 147).
tbieste
approved these changes
Nov 19, 2020
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the docs to reflect that
fhirServer/searchParameterFilterhas been replaced withfhirServer/resources/<resourceType>/searchParameters.We should probably add more documentation to explain
fhirServer/resources/<resourceType>/searchIncludes,fhirServer/resources/<resourceType>/searchRevIncludes, andfhirServer/resources/<resourceType>/searchParameterCombinations,but for now I just wanted to make sure the stale content was cleaned up.
I also added a section on using the new
$reindexoperation.Note that, rather than update them, I removed some examples and the description of the algorithm to reduce the burden of maintenance.
Review suggestion:
rather than viewing the diff, I think its easier to just read the new content at https://github.com/IBM/FHIR/blob/357cdcfc00f6614b1addc3ab32146b71e0202dbd/docs/src/pages/guides/FHIRSearchConfiguration.md
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com