-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #1602 - initial commit of helm chart #1848
Conversation
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
0eea9cb
to
6038dce
Compare
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
|
||
For example if you target the default namespace and name the release "postgres", | ||
then that would produce something like this: | ||
```sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not clear. where. this ends...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it ends on line 43, but I probably need to add some more stuff below there to describe how to actually use the chart. For now I just wanted to document a way of getting a postgresql in your cluster since I wanted to figure that out anyway
description: Helm chart for the IBM FHIR Server | ||
name: ibm-fhir-server | ||
version: 0.0.1 | ||
appVersion: 4.8.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be externalized? part of a strategy.matrix?
<!-- ============================================================== --> | ||
<!-- TENANT: default; DSID: default; TYPE: read-write --> | ||
<!-- ============================================================== --> | ||
<dataSource id="fhirDefaultDefault" jndiName="jdbc/fhir_default_default" type="javax.sql.XADataSource" statementCacheSize="200" syncQueryTimeoutWithTransactionTimeout="true" validationTimeout="30s"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know. we. added isolationLevel="TRANSACTION_READ_COMMITTED"
for. db2, do we need this for postgres?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure that Robin said its not needed for postgresql...something about the default being different for db2 and derby.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, makes sense. in another. repo
After discussing this with Paul and others, we've decided that it makes more sense to keep this helm chart out of this repo for now (so that it can be released on a separate cadence without polluting our Releases tab). Thus we have created a new repository under the Alvearie project and I've moved the content of this pull request to Alvearie/alvearie-helm#1 |
Introduces a helm chart for the IBM FHIR Server under
/charts
.Also introduces a github action for publishing the updated chart on our Releases tab
The chart uses helm hooks to execute the
ibmcom/ibm-fhir-schematool
image to create and update a database schema prior to deploying the updated application.TODOs
Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com