Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #1602 - initial commit of helm chart #1848

Closed
wants to merge 2 commits into from
Closed

issue #1602 - initial commit of helm chart #1848

wants to merge 2 commits into from

Conversation

lmsurpre
Copy link
Member

@lmsurpre lmsurpre commented Jan 6, 2021

Introduces a helm chart for the IBM FHIR Server under /charts.

Also introduces a github action for publishing the updated chart on our Releases tab

This uses @helm/chart-releaser-action to turn your GitHub project into a self-hosted Helm chart repo. It does this by checking each chart in your project, and whenever there's a new chart version, creates a corresponding GitHub release named for the chart version, adds Helm chart artifacts to the release, and creates or updates an index.yaml file with metadata about those releases, which is then hosted on GitHub Pages

The chart uses helm hooks to execute the ibmcom/ibm-fhir-schematool image to create and update a database schema prior to deploying the updated application.

TODOs

  1. Make it work with Db2

Signed-off-by: Lee Surprenant lmsurpre@us.ibm.com

@prb112 prb112 changed the base branch from master to main February 17, 2021 15:29
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre lmsurpre force-pushed the issue-1602 branch 2 times, most recently from 0eea9cb to 6038dce Compare July 6, 2021 19:52
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>

For example if you target the default namespace and name the release "postgres",
then that would produce something like this:
```sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not clear. where. this ends...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it ends on line 43, but I probably need to add some more stuff below there to describe how to actually use the chart. For now I just wanted to document a way of getting a postgresql in your cluster since I wanted to figure that out anyway

description: Helm chart for the IBM FHIR Server
name: ibm-fhir-server
version: 0.0.1
appVersion: 4.8.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be externalized? part of a strategy.matrix?

<!-- ============================================================== -->
<!-- TENANT: default; DSID: default; TYPE: read-write -->
<!-- ============================================================== -->
<dataSource id="fhirDefaultDefault" jndiName="jdbc/fhir_default_default" type="javax.sql.XADataSource" statementCacheSize="200" syncQueryTimeoutWithTransactionTimeout="true" validationTimeout="30s">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. we. added isolationLevel="TRANSACTION_READ_COMMITTED" for. db2, do we need this for postgres?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure that Robin said its not needed for postgresql...something about the default being different for db2 and derby.

Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, makes sense. in another. repo

@lmsurpre
Copy link
Member Author

lmsurpre commented Jul 9, 2021

After discussing this with Paul and others, we've decided that it makes more sense to keep this helm chart out of this repo for now (so that it can be released on a separate cadence without polluting our Releases tab). Thus we have created a new repository under the Alvearie project and I've moved the content of this pull request to Alvearie/alvearie-helm#1

@lmsurpre lmsurpre closed this Jul 9, 2021
@lmsurpre lmsurpre deleted the issue-1602 branch July 14, 2021 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants