Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes drop schema in PostgreSQL #2100

Merged
merged 5 commits into from
Mar 16, 2021
Merged

Fixes drop schema in PostgreSQL #2100

merged 5 commits into from
Mar 16, 2021

Conversation

punktilious
Copy link
Collaborator

@punktilious punktilious commented Mar 16, 2021

Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
@punktilious punktilious requested a review from lmsurpre March 16, 2021 21:04

To drop an IBM FHiR Server schema in PostgreSQL, set the following configuration in `postgresql.conf`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To drop an IBM FHiR Server schema in PostgreSQL, set the following configuration in `postgresql.conf`:
To drop an IBM FHIR Server schema in PostgreSQL, set the following configuration in `postgresql.conf`:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes - good catch!

Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Robin Arnold <robin.arnold23@ibm.com>
@punktilious punktilious added ci-skip Skips the CI Build and removed ci-skip Skips the CI Build labels Mar 16, 2021
@punktilious punktilious merged commit fabbb62 into main Mar 16, 2021
@punktilious punktilious deleted the postgres-drop-schema branch March 16, 2021 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants