Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2092, Issue #1733, Issue #1980 - miscellaneous updates #2161

Merged
merged 6 commits into from
Mar 29, 2021

Conversation

JohnTimm
Copy link
Collaborator

@JohnTimm JohnTimm commented Mar 27, 2021

Signed-off-by: John T.E. Timm johntimm@us.ibm.com

  1. Refactored common code for working with URLs into a utility class called URLSupport
  2. Created abstract base class for implicit value set registry resource providers
  3. Added getAncestorsAndSelf and getDescedantsAndSelf methods to CodeSystemSupport (for Support token modifiers ':above' and ':below' #1733)
  4. Added unit tests for 1. and 3.
  5. Added hasLabel("Concept") when ValueSet include filters list is empty

NOTE: I "sorted members" on CodeSystemSupport, therefore, it looks like more changes than are actually there. The only substantive changes are the addition of the new methods mentioned in 3. above.

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm changed the title Issue #2092, Issue #1733 - miscellaneous updates Issue #2092, Issue #1733, Issue #1980 - miscellaneous updates Mar 28, 2021
Copy link
Contributor

@michaelwschroeder michaelwschroeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a couple minor comments

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm merged commit 67e3e1f into main Mar 29, 2021
@JohnTimm JohnTimm deleted the johntimm-main branch March 29, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants