Issue #2163 - throw exception when filter cannot be applied / created #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
prb112
reviewed
Mar 30, 2021
fhir-term-graph/src/main/java/com/ibm/fhir/term/graph/util/FHIRTermGraphUtil.java
Show resolved
Hide resolved
prb112
reviewed
Mar 30, 2021
fhir-term/src/main/java/com/ibm/fhir/term/exception/FHIRTermException.java
Show resolved
Hide resolved
prb112
approved these changes
Mar 30, 2021
lmsurpre
reviewed
Mar 30, 2021
Comment on lines
+39
to
+41
| return concept.toBuilder() | ||
| .concept(Collections.emptyList()) | ||
| .build(); |
There was a problem hiding this comment.
why do we empty the concept list before returning it?
There was a problem hiding this comment.
We are flattening / removing the inherent concept hierarchy so that it more closely models what GraphTermServiceProvider returns. Consumers of these concepts care about code, display, designations and properties (not the inherent hierarchy).
There was a problem hiding this comment.
it might be worth adding a comment to explain that. maybe even to the parent javadoc to explain the contract for users of the FHIRTermServiceProvider interface.
There was a problem hiding this comment.
Asked John offline to address in upcoming PR
lmsurpre
reviewed
Mar 30, 2021
fhir-term/src/main/java/com/ibm/fhir/term/util/CodeSystemSupport.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Mar 30, 2021
fhir-term/src/main/java/com/ibm/fhir/term/util/CodeSystemSupport.java
Outdated
Show resolved
Hide resolved
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John T.E. Timm johntimm@us.ibm.com
FHIRTermExceptionfromCodeSystemSupportwhen concept filter cannot be createdFHIRTermServiceExceptionfromGraphTermServiceProviderandRegistryTermServiceProviderwhen filter cannot be applied or in response toFHIRTermExceptionbeing thrown fromCodeSystemSupportFHIRTermServiceProviderTestbase classCodeSystemSupportandRegistryTermServiceProviderto properly support normalization of code values and matchGraphTermServiceProviderimplementationtoObjectandtoLongmethods fromFHIRTermGraphUtiltoCodeSystemSupporttoSet(CodeSystem, Collection<Concept>)andtoString(Concept)utility methods to be reused in various places acrossCodeSystemSupport