Issue #1961 - Optionally reject references without resource type

[tbieste]

Issue #1961 - Optionally reject references without resource type

Signed-off-by: Troy Biesterfeld tbieste@us.ibm.com

[tbieste]

Need to regenerate fhir-examples, since many of them have malformed references.

[tbieste]

Summary of changes:

1. Updated fhirServer/core/checkReferenceTypes config (default: true) to also require resource type in refererences.
2. Added/updated testcases.
3. Updated AuditEventMapper to put the component id in reference.display instead of reference.reference.
4. Regenerated complete-mock examples (hence the large number of files), so reference ids are valid syntax.
5. Updated a few spec examples, since a few included invalid resource types in references that did not match the spec.
6. Opened $apply operation error when specifying practitioner #2240, which I found while running fhir-server-test testcases.

[prb112]

left some comments

[lmsurpre]

Updated a few spec examples, since a few included invalid resource types in references that did not match the spec.

We usually try to keep some kind of change log when we edit spec artifacts.
The other option is to just mark them as invalid in our index...then they actually just become negative test cases.

[tbieste]

Updated a few spec examples, since a few included invalid resource types in references that did not match the spec.

We usually try to keep some kind of change log when we edit spec artifacts.
The other option is to just mark them as invalid in our index...then they actually just become negative test cases.

I think all the spec example references that didn't include valid resource types started with "http:" or ":https", so I can revert those spec example changes if I skip validation of those as you suggested in another comment.

[lmsurpre]

LGTM

[tbieste]

Comments addressed. Ready to merge.