Add configuration property defaultPageSize #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This address LinuxForHealth#2229 by creating a configuration property fhirServer/core/defaultPageSize that controls the number of records retrieved by search when no _count parameter is specified in the request. This parameter honors SearchConstants.MAX_PAGE_SIZE (1000). If the server configuration specifies a value greater than MAX_PAGE_SIZE, a warning is logged and MAX_PAGE_SIZE is used. When no configuration property is specified the previous default FHIRConstants.FHIR_PAGE_SIZE_DEFAULT (10) will be used. Signed-off-by: Corey Sanders <corey.thecolonel@gmail.com>
Signed-off-by: Corey Sanders <corey.thecolonel@gmail.com>
lmsurpre
reviewed
Apr 12, 2021
| @@ -1953,6 +1953,7 @@ This section contains reference information about each of the configuration prop | |||
| |`fhirServer/core/capabilityStatementCacheTimeout`|integer|The number of minutes that a tenant's CapabilityStatement is cached for the metadata endpoint. | | |||
| |`fhirServer/core/extendedCodeableConceptValidation`|boolean|A boolean flag which indicates whether extended validation is performed by the server during object construction for code, Coding, CodeableConcept, Quantity, Uri, and String elements which have required bindings to value sets.| | |||
| |`fhirServer/core/disabledOperations`|string|A comma-separated list of operations which are not allowed to run on the IBM FHIR Server, for example, `validate,import`. Note, do not include the dollar sign `$`| | |||
| |`fhirServer/core/defaultPageSize`|integer|Sets the pageSize to use in search when no _count parameter is specified in the request. If a user-specified value exceeds the max page size (1000), then a warning is logged and max page size will be used. If not provided, the default page size (10) is used.| | |||
There was a problem hiding this comment.
I assume it applies to history interactions as well
Suggested change
| |`fhirServer/core/defaultPageSize`|integer|Sets the pageSize to use in search when no _count parameter is specified in the request. If a user-specified value exceeds the max page size (1000), then a warning is logged and max page size will be used. If not provided, the default page size (10) is used.| | |
| |`fhirServer/core/defaultPageSize`|integer|Sets the pageSize to use in search and history interactions when no _count parameter is specified in the request. If a user-specified value exceeds the max page size (1000), then a warning is logged and max page size will be used. If not provided, the default page size (10) is used.| |
There was a problem hiding this comment.
Also, its a bit confusing, but we have 3 separate tables in section 5.1. You added this property to the table that has the description. However, 5.1.2 has the default value and 5.1.3 indicates whether the parameter is tenant-specific (different values allowed for different tenants) and dynamic (changes take affect without a server restart).
We used to have all of this in a single table, but it was too wide for just about any documentation format.
For 5.1.2, just add a row and indicate the default is 10.
For 5.1.3, since you're using FHIRConfigHelper, this property will be dynamic and tenant-specific, so thats just Y|Y.
lmsurpre
reviewed
Apr 12, 2021
fhir-search/src/main/java/com/ibm/fhir/search/context/FHIRSearchContextFactory.java
Show resolved
Hide resolved
lmsurpre
reviewed
Apr 12, 2021
fhir-search/src/test/java/com/ibm/fhir/search/context/FHIRSearchContextFactoryTest.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Apr 12, 2021
fhir-search/src/main/java/com/ibm/fhir/search/context/FHIRSearchContextFactory.java
Outdated
Show resolved
Hide resolved
- doc updates - copyright fixes - remove log guards on warning messages Signed-off-by: Corey Sanders <corey.thecolonel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This address #2229 by creating a configuration property
fhirServer/core/defaultPageSize that controls the number of records
retrieved by search and history when no _count parameter is specified in the
request. This parameter honors SearchConstants.MAX_PAGE_SIZE (1000). If
the server configuration specifies a value greater than MAX_PAGE_SIZE, a
warning is logged and MAX_PAGE_SIZE is used. When no configuration
property is specified the previous default
FHIRConstants.FHIR_PAGE_SIZE_DEFAULT (10) will be used.
Signed-off-by: Corey Sanders corey.thecolonel@gmail.com