Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2198 - getConcept should return null for responses other than 200 #2261

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

JohnTimm
Copy link
Collaborator

Signed-off-by: John T.E. Timm johntimm@us.ibm.com

RemoteTermServiceProvider.getConcept throws an Exception for responses other than OK (200). However, in order to be aligned with the getConcept contract, we should return null instead.

Signed-off-by: John T.E. Timm <johntimm@us.ibm.com>
@JohnTimm JohnTimm requested review from lmsurpre and prb112 April 21, 2021 15:25
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JohnTimm JohnTimm merged commit 8d76f89 into main Apr 21, 2021
@JohnTimm JohnTimm deleted the johntimm-main branch April 21, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants